[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Menu branch
From: Ignat Semenov <ignat.semenov () blue-systems ! com>
Date: 2013-04-19 7:32:48
Message-ID: 5170f330.6a8d700a.5cb2.15aa () mx ! google ! com
[Download RAW message or body]
Hello,
git.k.o is finally up again, so here we go:
- Split the flow enum in two - a mega-patch with a mega-commit-message
- Re-did the UI with 4 categories
Concerns:
setLayout() and setAlignment() both trigger a complete relayout of the view.
Relayouting the view twice is suboptimal, however, in the code there is a
10ms timer to delay the relayout so as not to block the caller. Should that
timer be enough to ensure that when those two funcitons are called one after
another, the view is only relayouted once? Maybe increase the delay a bit?
Other than that, the split has made the code way more readable, in my
opinion, not to say the it is now easier to configure the layout (I have had
troubles wrapping my head around the top to bottom right to left stuff as
well).
Best regards,
Ignat Semenov
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic