'Re: Review Request 109993: Sort Folder View preview popup by default if main view is unsorted'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request 109993: Sort Folder View preview popup by default if main view is unsorted
From:       "Eike Hein" <hein () kde ! org>
Date:       2013-04-15 8:45:14
Message-ID: 20130415084514.11244.50008 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109993/
-----------------------------------------------------------

(Updated April 15, 2013, 8:45 a.m.)

Status
------

This change has been marked as submitted.

Review request for Plasma.

Description
-------

This patch changes the Folder View preview popup behavior to apply sorting by default \
if the main view is unsorted. Previously, the preview popup would always adopt the \
sorting settings of the main view, including doing no sorting at all. The default \
sorting now applied instead mirrors the default sorting used by Folder View. If the \
main view is sorted in some way, however, the popup still follows its settings as \
before.

Rationale: The main view enters an unsorted mode when the user manually rearranges \
icons. Manual rearranging is not supported by preview popups and preview popups save \
no state, so unsorted mode is not useful in preview popups. Preview popups are more \
useful if they are sorted by default, since there is no user-set arrangement this \
would override. Sorted by default beats random by default.

I would like to apply this patch to both the KDE/4.10 and master branches.

Diffs
-----

  plasma/applets/folderview/popupview.cpp c6e881b 

Diff: http://git.reviewboard.kde.org/r/109993/diff/

Testing
-------

Thanks,

Eike Hein

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/109993/">http://git.reviewboard.kde.org/r/109993/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#e0e0e0" width="100%" cellpadding="8" style="border: 1px gray \
solid;">  <tr>
  <td>
   <h1 style="margin-right: 0.2em; padding: 0; font-size: 10pt;">This change has been \
marked as submitted.</h1>  </td>
 </tr>
</table>
<br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for Plasma.</div>
<div>By Eike Hein.</div>

<p style="color: grey;"><i>Updated April 15, 2013, 8:45 a.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">This patch changes the Folder View preview popup behavior to apply \
sorting by default if the main view is unsorted. Previously, the preview popup would \
always adopt the sorting settings of the main view, including doing no sorting at \
all. The default sorting now applied instead mirrors the default sorting used by \
Folder View. If the main view is sorted in some way, however, the popup still follows \
its settings as before.

Rationale: The main view enters an unsorted mode when the user manually rearranges \
icons. Manual rearranging is not supported by preview popups and preview popups save \
no state, so unsorted mode is not useful in preview popups. Preview popups are more \
useful if they are sorted by default, since there is no user-set arrangement this \
would override. Sorted by default beats random by default.

I would like to apply this patch to both the KDE/4.10 and master branches.</pre>
  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>plasma/applets/folderview/popupview.cpp <span style="color: \
grey">(c6e881b)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/109993/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[prev in list] [next in list] [prev in thread] [next in thread] 