[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request 109773: New runner that translates words and sentences via Google Translate.
From: "David Baum" <mail () naraesk ! eu>
Date: 2013-04-14 23:18:20
Message-ID: 20130414231820.9454.38388 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
> On April 8, 2013, 5:39 p.m., Aaron J. Seigo wrote:
> > runners/translator/translator.cpp, lines 116-117
> > <http://git.reviewboard.kde.org/r/109773/diff/5/?file=131524#file131524line116>
> >
> > might be nice to pop a small comment here why this is required
Google responds with a JSON array like this: ["foo",,"bar"]. Unfortunately this is \
nod valid JSON, QJSON expects ["foo","","bar"]. I added a comment in the code.
> On April 8, 2013, 5:39 p.m., Aaron J. Seigo wrote:
> > runners/translator/translator.cpp, line 131
> > <http://git.reviewboard.kde.org/r/109773/diff/5/?file=131524#file131524line131>
> >
> > l0 is not a great variable name. please name it something descriptive to its \
> > purpose.
You're right. Hope it's better now.
> On April 8, 2013, 5:39 p.m., Aaron J. Seigo wrote:
> > runners/translator/translator.cpp, lines 184-192
> > <http://git.reviewboard.kde.org/r/109773/diff/5/?file=131524#file131524line184>
> >
> > i would suggest taking advantage of the fact that QMap is sorted. in the while \
> > loop, the code already does a check for i.key() == key, so one may as well do \
> > that from the start and do something like:
> > QMapIterator<int, QPair<QString, double> > it(sentences);
> > int currentKey = -1;
> > double currentRel = 1;
> > QString currentString;
> >
> > while (it.hasNext()) {
> > pair = it.next();
> >
> > // we're on to another key, process previous results, if any
> > if (currentKey != it.key()) {
> >
> > if (!combined.isEmpty()) {
> > Plasma::QueryMatch match(this);
> > .. setup match ..
> > combined.clear();
> > }
> >
> > currentKey = it.key();
> > currentRel = 1;
> > currentString.clear();
> > }
> >
> > currentString.append(' ').append(pair.first);
> > currentRel *= pair.second;
> > }
> >
> > this woudl avoid the more expensive calls of uniqueKeys and find and make the \
> > code a lot easier to read. (assuming it does what i think it does from reading it \
> > :)
Nice! And yes, it does what you think it does. ;-)
- David
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109773/#review30684
-----------------------------------------------------------
On April 15, 2013, 1:17 a.m., David Baum wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/109773/
> -----------------------------------------------------------
>
> (Updated April 15, 2013, 1:17 a.m.)
>
>
> Review request for Plasma.
>
>
> Description
> -------
>
> The Runner uses the Google Translate Homepage and supports all languages provided \
> by Google. It doesn't use the API, because it's not free of charge.
>
> Diffs
> -----
>
> runners/CMakeLists.txt bb4b491b10e6fef8183a66f55f5d5832dd7bc41a
> runners/translator/CMakeLists.txt PRE-CREATION
> runners/translator/plasma-runner-translator.desktop PRE-CREATION
> runners/translator/translator.h PRE-CREATION
> runners/translator/translator.cpp PRE-CREATION
> runners/translator/translatorjob.h PRE-CREATION
> runners/translator/translatorjob.cpp PRE-CREATION
>
> Diff: http://git.reviewboard.kde.org/r/109773/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> David Baum
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/109773/">http://git.reviewboard.kde.org/r/109773/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On April 8th, 2013, 5:39 p.m. CEST, <b>Aaron J. \
Seigo</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="http://git.reviewboard.kde.org/r/109773/diff/5/?file=131524#file131524line116" \
style="color: black; font-weight: bold; text-decoration: \
underline;">runners/translator/translator.cpp</a> <span style="font-weight: \
normal;">
(Diff revision 5)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">116</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="n">jsonData</span> <span class="o">=</span> <span \
class="n">jsonData</span><span class="p">.</span><span class="n">replace</span><span \
class="p">(</span><span class="n">QRegExp</span><span class="p">(</span><span \
class="s">",{3,3}"</span><span class="p">),</span> <span \
class="s">",</span><span class="se">\"\"</span><span \
class="s">,</span><span class="se">\"\"</span><span \
class="s">,"</span><span class="p">);</span></pre></td> </tr>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">117</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="n">jsonData</span> <span class="o">=</span> <span \
class="n">jsonData</span><span class="p">.</span><span class="n">replace</span><span \
class="p">(</span><span class="n">QRegExp</span><span class="p">(</span><span \
class="s">",{2,2}"</span><span class="p">),</span> <span \
class="s">",</span><span class="se">\"\"</span><span \
class="s">,"</span><span class="p">);</span></pre></td> </tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">might be nice to pop a \
small comment here why this is required</pre> </blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Google \
responds with a JSON array like this: ["foo",,"bar"]. \
Unfortunately this is nod valid JSON, QJSON expects \
["foo","","bar"]. I added a comment in the code.</pre>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On April 8th, 2013, 5:39 p.m. CEST, <b>Aaron J. \
Seigo</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="http://git.reviewboard.kde.org/r/109773/diff/5/?file=131524#file131524line131" \
style="color: black; font-weight: bold; text-decoration: \
underline;">runners/translator/translator.cpp</a> <span style="font-weight: \
normal;">
(Diff revision 5)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">131</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span \
class="tb"> </span><span class="n">foreach</span> <span class="p">(</span><span \
class="k">const</span> <span class="n">QVariant</span> <span \
class="o">&</span><span class="n">l0</span><span class="p">,</span> <span \
class="n">json</span><span class="p">)</span> <span class="p">{</span></pre></td> \
</tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">l0 is not a great \
variable name. please name it something descriptive to its purpose.</pre> \
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">You're \
right. Hope it's better now.</pre> <br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On April 8th, 2013, 5:39 p.m. CEST, <b>Aaron J. \
Seigo</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="http://git.reviewboard.kde.org/r/109773/diff/5/?file=131524#file131524line184" \
style="color: black; font-weight: bold; text-decoration: \
underline;">runners/translator/translator.cpp</a> <span style="font-weight: \
normal;">
(Diff revision 5)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">184</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span \
class="tb"> </span><span class="tb"> </span><span class="n">QList</span><span \
class="o"><</span><span class="kt">int</span><span class="o">></span> <span \
class="n">keys</span> <span class="o">=</span> <span class="n">sentences</span><span \
class="p">.</span><span class="n">uniqueKeys</span><span \
class="p">();</span></pre></td> </tr>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">185</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span \
class="tb"> </span><span class="tb"> </span><span class="n">QList</span><span \
class="o"><</span><span class="n">QPair</span><span class="o"><</span><span \
class="n">QString</span><span class="p">,</span> <span class="kt">double</span><span \
class="o">></span> <span class="o">></span> <span \
class="n">combined</span><span class="p">;</span></pre></td> </tr>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">186</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span \
class="tb"> </span><span class="tb"> </span><span class="n">QPair</span><span \
class="o"><</span><span class="n">QString</span><span class="p">,</span> <span \
class="kt">double</span><span class="o">></span> <span class="n">pair</span><span \
class="p">;</span></pre></td> </tr>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">187</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> \
</tr>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">188</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span \
class="tb"> </span><span class="tb"> </span><span class="n">foreach</span> <span \
class="p">(</span><span class="k">const</span> <span class="kt">int</span> <span \
class="n">k</span><span class="p">,</span> <span class="n">keys</span><span \
class="p">)</span> <span class="p">{</span></pre></td> </tr>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">189</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span \
class="tb"> </span><span class="tb"> </span><span class="tb"> </span><span \
class="n">QList</span><span class="o"><</span><span class="n">QPair</span><span \
class="o"><</span><span class="n">QString</span><span class="p">,</span> <span \
class="kt">double</span><span class="o">></span> <span class="o">></span> <span \
class="n">tmp</span> <span class="o">=</span> <span class="n">combined</span><span \
class="p">;</span></pre></td> </tr>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">190</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span \
class="tb"> </span><span class="tb"> </span><span class="tb"> </span><span \
class="n">combined</span><span class="p">.</span><span class="n">clear</span><span \
class="p">();</span></pre></td> </tr>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">191</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span \
class="tb"> </span><span class="tb"> </span><span class="tb"> </span><span \
class="n">QMultiMap</span><span class="o"><</span><span class="kt">int</span><span \
class="p">,</span> <span class="n">QPair</span><span class="o"><</span><span \
class="n">QString</span><span class="p">,</span> <span class="kt">double</span><span \
class="o">></span> <span class="o">>::</span><span \
class="n">const_iterator</span> <span class="n">i</span> <span class="o">=</span> \
<span class="n">sentences</span><span class="p">.</span><span \
class="n">find</span><span class="p">(</span><span class="n">k</span><span \
class="p">);</span></pre></td> </tr>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">192</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span \
class="tb"> </span><span class="tb"> </span><span class="tb"> </span><span \
class="k">while</span> <span class="p">(</span><span class="n">i</span> <span \
class="o">!=</span> <span class="n">sentences</span><span class="p">.</span><span \
class="n">end</span><span class="p">()</span> <span class="o">&&</span> <span \
class="n">i</span><span class="p">.</span><span class="n">key</span><span \
class="p">()</span> <span class="o">==</span> <span class="n">k</span><span \
class="p">)</span> <span class="p">{</span></pre></td> </tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">i would suggest taking \
advantage of the fact that QMap is sorted. in the while loop, the code already does a \
check for i.key() == key, so one may as well do that from the start and do something \
like:
QMapIterator<int, QPair<QString, double> > it(sentences);
int currentKey = -1;
double currentRel = 1;
QString currentString;
while (it.hasNext()) {
pair = it.next();
// we're on to another key, process previous results, if any
if (currentKey != it.key()) {
if (!combined.isEmpty()) {
Plasma::QueryMatch match(this);
.. setup match ..
combined.clear();
}
currentKey = it.key();
currentRel = 1;
currentString.clear();
}
currentString.append(' ').append(pair.first);
currentRel *= pair.second;
}
this woudl avoid the more expensive calls of uniqueKeys and find and make the code a \
lot easier to read. (assuming it does what i think it does from reading it :)</pre> \
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Nice! And \
yes, it does what you think it does. ;-)</pre> <br />
<p>- David</p>
<br />
<p>On April 15th, 2013, 1:17 a.m. CEST, David Baum wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Plasma.</div>
<div>By David Baum.</div>
<p style="color: grey;"><i>Updated April 15, 2013, 1:17 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">The Runner uses the Google Translate Homepage and supports all languages \
provided by Google. It doesn't use the API, because it's not free of charge. \
</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>runners/CMakeLists.txt <span style="color: \
grey">(bb4b491b10e6fef8183a66f55f5d5832dd7bc41a)</span></li>
<li>runners/translator/CMakeLists.txt <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>runners/translator/plasma-runner-translator.desktop <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>runners/translator/translator.h <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>runners/translator/translator.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>runners/translator/translatorjob.h <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>runners/translator/translatorjob.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/109773/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic