'Re: Review Request 109821: make the DvcsJob async'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request 109821: make the DvcsJob async
From:       "Commit Hook" <null () kde ! org>
Date:       2013-04-11 10:28:40
Message-ID: 20130411102840.29379.19964 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109821/
-----------------------------------------------------------

(Updated April 11, 2013, 10:28 a.m.)

Status
------

This change has been marked as submitted.

Review request for Plasma.

Description
-------

This patch implements a proper KJob and uses the job as an async when
and where it makes sense.

My opinion about the patch(feel free to ignore it:)
I tried to make all the jobs async but in some cases it was an overhead
and the code was looking bad, so I implemented the execSynchrousnly in order
to emphasize that the job is sync and to have a better result.

Diffs
-----

  plasmate/savesystem/timeline.cpp 4293dae 
  plasmate/savesystem/timeline.h 95e7e97 
  plasmate/savesystem/gitrunner.cpp 7520239 
  plasmate/savesystem/gitrunner.h dfacc5b 
  plasmate/savesystem/dvcsjob.cpp 6f83307 
  plasmate/savesystem/dvcsjob.h 38df371 

Diff: http://git.reviewboard.kde.org/r/109821/diff/

Testing
-------

I haven't found any regressions.

Thanks,

Giorgos Tsiapaliokas

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/109821/">http://git.reviewboard.kde.org/r/109821/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#e0e0e0" width="100%" cellpadding="8" style="border: 1px gray \
solid;">  <tr>
  <td>
   <h1 style="margin-right: 0.2em; padding: 0; font-size: 10pt;">This change has been \
marked as submitted.</h1>  </td>
 </tr>
</table>
<br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for Plasma.</div>
<div>By Giorgos Tsiapaliokas.</div>

<p style="color: grey;"><i>Updated April 11, 2013, 10:28 a.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">This patch implements a proper KJob and uses the job as an async when \
and where it makes sense.

My opinion about the patch(feel free to ignore it:)
I tried to make all the jobs async but in some cases it was an overhead
and the code was looking bad, so I implemented the execSynchrousnly in order
to emphasize that the job is sync and to have a better result.</pre>
  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">I haven&#39;t found any regressions.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>plasmate/savesystem/timeline.cpp <span style="color: grey">(4293dae)</span></li>

 <li>plasmate/savesystem/timeline.h <span style="color: grey">(95e7e97)</span></li>

 <li>plasmate/savesystem/gitrunner.cpp <span style="color: \
grey">(7520239)</span></li>

 <li>plasmate/savesystem/gitrunner.h <span style="color: grey">(dfacc5b)</span></li>

 <li>plasmate/savesystem/dvcsjob.cpp <span style="color: grey">(6f83307)</span></li>

 <li>plasmate/savesystem/dvcsjob.h <span style="color: grey">(38df371)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/109821/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[prev in list] [next in list] [prev in thread] [next in thread] 