'Re: Review Request 109947: KTp Chat plasmoid: Improve integration with hiding panels'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request 109947: KTp Chat plasmoid: Improve integration with hiding panels
From:       "Commit Hook" <null () kde ! org>
Date:       2013-04-10 22:48:12
Message-ID: 20130410224812.9974.8017 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109947/#review30888
-----------------------------------------------------------

This review has been submitted with commit ef2f99673c1e56086d68899003e190540e99565e \
by Aleix Pol to branch kde-telepathy-0.6.

- Commit Hook

On April 10, 2013, 10:47 p.m., Aleix Pol Gonzalez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/109947/
> -----------------------------------------------------------
> 
> (Updated April 10, 2013, 10:47 p.m.)
> 
> 
> Review request for Plasma, Telepathy and David Edmundson.
> 
> 
> Description
> -------
> 
> This patch changes 2 things:
> - changes the code from a js function to setting a qml property. This is better \
> because we don't have to connect to all the changing signals to re-evaluate (there \
>                 were some weird problems in this regard).
> - Also it makes it so when you have a dialog opened, the status is set to \
> AcceptingInputStatus, this way the panel doesn't hide while you're writing. This is \
> useful because this way you can see if somebody talks to you while you're chatting \
> already. 
> 
> Diffs
> -----
> 
> chat/org.kde.ktp-chat/contents/ui/main.qml 9fb78c9 
> 
> Diff: http://git.reviewboard.kde.org/r/109947/diff/
> 
> 
> Testing
> -------
> 
> Self-conversation, as usual.
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
> 

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/109947/">http://git.reviewboard.kde.org/r/109947/</a>
  </td>
    </tr>
   </table>
   <br />

 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been \
submitted with commit ef2f99673c1e56086d68899003e190540e99565e by Aleix Pol to branch \
kde-telepathy-0.6.</pre>  <br />

<p>- Commit</p>

<br />
<p>On April 10th, 2013, 10:47 p.m. UTC, Aleix Pol Gonzalez wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for Plasma, Telepathy and David Edmundson.</div>
<div>By Aleix Pol Gonzalez.</div>

<p style="color: grey;"><i>Updated April 10, 2013, 10:47 p.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
                break-word;">This patch changes 2 things:
- changes the code from a js function to setting a qml property. This is better \
because we don&#39;t have to connect to all the changing signals to re-evaluate \
                (there were some weird problems in this regard).
- Also it makes it so when you have a dialog opened, the status is set to \
AcceptingInputStatus, this way the panel doesn&#39;t hide while you&#39;re writing. \
This is useful because this way you can see if somebody talks to you while you&#39;re \
chatting already.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Self-conversation, as usual.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>chat/org.kde.ktp-chat/contents/ui/main.qml <span style="color: \
grey">(9fb78c9)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/109947/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[prev in list] [next in list] [prev in thread] [next in thread] 