'Re: Review Request 109793: Check network connection before starting youtube and mediawiki runners'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request 109793: Check network connection before starting youtube and mediawiki runners
From:       "Commit Hook" <null () kde ! org>
Date:       2013-04-09 13:01:47
Message-ID: 20130409130147.26820.93542 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109793/#review30783
-----------------------------------------------------------

This review has been submitted with commit a93c4bfd8f6464d8a4ffafec1bca98f67da06747 \
by Maarten De Meyer to branch KDE/4.10.

- Commit Hook

On April 8, 2013, 3:43 p.m., Maarten De Meyer wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/109793/
> -----------------------------------------------------------
> 
> (Updated April 8, 2013, 3:43 p.m.)
> 
> 
> Review request for Plasma, Sebastian Kügler and Shaun Reich.
> 
> 
> Description
> -------
> 
> Check the network connection before running the mediawiki and youtube runner. We \
> could make it wait for a connection, now you need to change the query. This needs \
> solid networking. 
> Do I need to add a macro_log_feature for solid in the main CMakelists.txt file?
> In what branch does this go if accepted? (master and frameworks?)
> 
> 
> Diffs
> -----
> 
> runners/mediawiki/CMakeLists.txt 1e9a67a 
> runners/mediawiki/mediawikirunner.cpp 91d78f3 
> runners/youtube/CMakeLists.txt 639d403 
> runners/youtube/youtube.cpp a16e40b 
> 
> Diff: http://git.reviewboard.kde.org/r/109793/diff/
> 
> 
> Testing
> -------
> 
> Compiled and run.
> 
> 
> Thanks,
> 
> Maarten De Meyer
> 
> 

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/109793/">http://git.reviewboard.kde.org/r/109793/</a>
  </td>
    </tr>
   </table>
   <br />

 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been \
submitted with commit a93c4bfd8f6464d8a4ffafec1bca98f67da06747 by Maarten De Meyer to \
branch KDE/4.10.</pre>  <br />

<p>- Commit</p>

<br />
<p>On April 8th, 2013, 3:43 p.m. UTC, Maarten De Meyer wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for Plasma, Sebastian Kügler and Shaun Reich.</div>
<div>By Maarten De Meyer.</div>

<p style="color: grey;"><i>Updated April 8, 2013, 3:43 p.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Check the network connection before running the mediawiki and youtube \
runner. We could make it wait for a connection, now you need to change the query. \
This needs solid networking.

Do I need to add a macro_log_feature for solid in the main CMakelists.txt file?
In what branch does this go if accepted? (master and frameworks?)</pre>
  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Compiled and run.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>runners/mediawiki/CMakeLists.txt <span style="color: grey">(1e9a67a)</span></li>

 <li>runners/mediawiki/mediawikirunner.cpp <span style="color: \
grey">(91d78f3)</span></li>

 <li>runners/youtube/CMakeLists.txt <span style="color: grey">(639d403)</span></li>

 <li>runners/youtube/youtube.cpp <span style="color: grey">(a16e40b)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/109793/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[prev in list] [next in list] [prev in thread] [next in thread] 