[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request 109607: Remove Google Gadgets support
From: "Commit Hook" <null () kde ! org>
Date: 2013-04-01 11:08:58
Message-ID: 20130401110858.14426.58923 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109607/
-----------------------------------------------------------
(Updated April 1, 2013, 11:08 a.m.)
Status
------
This change has been marked as submitted.
Review request for kde-workspace and Plasma.
Description
-------
Google Gadgets does not currently work properly and has a dead upstream. Downstreams \
such as Fedora and openSUSE no longer ship it.
This patch removes support for it entirely.
Diffs
-----
CMakeLists.txt 06b779b5d4121178f0999a9fc69602445d5db7ea
cmake/modules/CMakeLists.txt 8d3d58189dbcb9e89d4d9c9aa4f3c1c93abad5e4
cmake/modules/FindGooglegadgets.cmake 9d35dbdf9036e9ffd3e8a83f8223728c427171f2
doc/plasma-desktop/index.docbook 8d32813805cdd356e60b80976b1c07f6c9291999
plasma/design/plasmoids ac73ea5cb0eb1e1f94810b1694a4b654fa63f4f2
plasma/design/security f9fb0cb2f32b80d1ebf7d6c22b83f36cfaa460b8
plasma/generic/scriptengines/CMakeLists.txt \
864e830cf092d52afaa45936ab8b5bee0a3170f7 \
plasma/generic/scriptengines/google_gadgets/CMakeLists.txt \
bb6cd7faeb49543f9cd399a01a1784ad99536be1 \
plasma/generic/scriptengines/google_gadgets/Messages.sh \
ffd3b53a8912c96090df7ae8468df176bc42f975 \
plasma/generic/scriptengines/google_gadgets/README \
9a3b195e7117aa42f52ad484cbcbc714edb585e7 \
plasma/generic/scriptengines/google_gadgets/config.txt.tmpl \
430c66418035c50c028877fd71d012cd82f9a025 \
plasma/generic/scriptengines/google_gadgets/floating_decorator.h \
e45c4a5de85614b278a4a5fbe3f258b422a19281 \
plasma/generic/scriptengines/google_gadgets/floating_decorator.cpp \
05756c76df00c0fa45aa20f0cf05a9a04282c1c1 \
plasma/generic/scriptengines/google_gadgets/ggl_applet_script.h \
f1564f73e98ffd81c2192e5801946484a10ca065 \
plasma/generic/scriptengines/google_gadgets/ggl_applet_script.cpp \
e617a08b2c6ccdd875ab4c0dd1d1e58a3b921d99 \
plasma/generic/scriptengines/google_gadgets/ggl_extensions.h \
e1ecb2873eb5a372b8557bb071158dc9dd5dc9d6 \
plasma/generic/scriptengines/google_gadgets/ggl_package.h \
062e29c0251be508161b9b6ad21236a8f68ddca5 \
plasma/generic/scriptengines/google_gadgets/ggl_package.cpp \
081a9d26269961c08bf2a9ab88647f0b08b98297 \
plasma/generic/scriptengines/google_gadgets/panel_decorator.h \
e82d43d6a5a17c76efad00b6d0952928d5c9263d \
plasma/generic/scriptengines/google_gadgets/panel_decorator.cpp \
16896ae8873b1a461608004b52d7246a2a6ec69a \
plasma/generic/scriptengines/google_gadgets/plasma-applet-ggl.desktop.tmpl \
3ca7fce9eb665596c63ba7fe42f548e3063ffcb0 \
plasma/generic/scriptengines/google_gadgets/plasma-packagestructure-googlegadgets.desktop \
c0436d7bbda62da45c9e06bd1c38bad12fbef808 \
plasma/generic/scriptengines/google_gadgets/plasma-scriptengine-googlegadgets.desktop \
1633ccef39d751703ff44d0bcff86fd737e58c61 \
plasma/generic/scriptengines/google_gadgets/plasma_host.h \
41b41362ef107759e22703d0f533e79a2f5f7d18 \
plasma/generic/scriptengines/google_gadgets/plasma_host.cpp \
3134a47c8ce9b9ded2bf14ce96eee8a79d31ebf3 \
plasma/generic/scriptengines/google_gadgets/plasma_view_host.h \
8c6f3abdaf21682b09686b4ec663d3dae982cfe0 \
plasma/generic/scriptengines/google_gadgets/plasma_view_host.cpp \
cd7cb07f95f8d5bf3023f50fdac427774340e776 \
plasma/generic/scriptengines/google_gadgets/plasma_view_host_internal.h \
ed69f657305be8d056285c9714c0e97eaaaf107a \
plasma/generic/scriptengines/google_gadgets/popout_decorator.h \
01a5671c73747852b89b495a6e6012d97df51cf7 \
plasma/generic/scriptengines/google_gadgets/popout_decorator.cpp \
11d6a463a467ccf3a6810aed9d595906b67e8aac
Diff: http://git.reviewboard.kde.org/r/109607/diff/
Testing
-------
Thanks,
Michael Palimaka
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/109607/">http://git.reviewboard.kde.org/r/109607/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#e0e0e0" width="100%" cellpadding="8" style="border: 1px gray \
solid;"> <tr>
<td>
<h1 style="margin-right: 0.2em; padding: 0; font-size: 10pt;">This change has been \
marked as submitted.</h1> </td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for kde-workspace and Plasma.</div>
<div>By Michael Palimaka.</div>
<p style="color: grey;"><i>Updated April 1, 2013, 11:08 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Google Gadgets does not currently work properly and has a dead upstream. \
Downstreams such as Fedora and openSUSE no longer ship it.
This patch removes support for it entirely.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>CMakeLists.txt <span style="color: \
grey">(06b779b5d4121178f0999a9fc69602445d5db7ea)</span></li>
<li>cmake/modules/CMakeLists.txt <span style="color: \
grey">(8d3d58189dbcb9e89d4d9c9aa4f3c1c93abad5e4)</span></li>
<li>cmake/modules/FindGooglegadgets.cmake <span style="color: \
grey">(9d35dbdf9036e9ffd3e8a83f8223728c427171f2)</span></li>
<li>doc/plasma-desktop/index.docbook <span style="color: \
grey">(8d32813805cdd356e60b80976b1c07f6c9291999)</span></li>
<li>plasma/design/plasmoids <span style="color: \
grey">(ac73ea5cb0eb1e1f94810b1694a4b654fa63f4f2)</span></li>
<li>plasma/design/security <span style="color: \
grey">(f9fb0cb2f32b80d1ebf7d6c22b83f36cfaa460b8)</span></li>
<li>plasma/generic/scriptengines/CMakeLists.txt <span style="color: \
grey">(864e830cf092d52afaa45936ab8b5bee0a3170f7)</span></li>
<li>plasma/generic/scriptengines/google_gadgets/CMakeLists.txt <span style="color: \
grey">(bb6cd7faeb49543f9cd399a01a1784ad99536be1)</span></li>
<li>plasma/generic/scriptengines/google_gadgets/Messages.sh <span style="color: \
grey">(ffd3b53a8912c96090df7ae8468df176bc42f975)</span></li>
<li>plasma/generic/scriptengines/google_gadgets/README <span style="color: \
grey">(9a3b195e7117aa42f52ad484cbcbc714edb585e7)</span></li>
<li>plasma/generic/scriptengines/google_gadgets/config.txt.tmpl <span style="color: \
grey">(430c66418035c50c028877fd71d012cd82f9a025)</span></li>
<li>plasma/generic/scriptengines/google_gadgets/floating_decorator.h <span \
style="color: grey">(e45c4a5de85614b278a4a5fbe3f258b422a19281)</span></li>
<li>plasma/generic/scriptengines/google_gadgets/floating_decorator.cpp <span \
style="color: grey">(05756c76df00c0fa45aa20f0cf05a9a04282c1c1)</span></li>
<li>plasma/generic/scriptengines/google_gadgets/ggl_applet_script.h <span \
style="color: grey">(f1564f73e98ffd81c2192e5801946484a10ca065)</span></li>
<li>plasma/generic/scriptengines/google_gadgets/ggl_applet_script.cpp <span \
style="color: grey">(e617a08b2c6ccdd875ab4c0dd1d1e58a3b921d99)</span></li>
<li>plasma/generic/scriptengines/google_gadgets/ggl_extensions.h <span style="color: \
grey">(e1ecb2873eb5a372b8557bb071158dc9dd5dc9d6)</span></li>
<li>plasma/generic/scriptengines/google_gadgets/ggl_package.h <span style="color: \
grey">(062e29c0251be508161b9b6ad21236a8f68ddca5)</span></li>
<li>plasma/generic/scriptengines/google_gadgets/ggl_package.cpp <span style="color: \
grey">(081a9d26269961c08bf2a9ab88647f0b08b98297)</span></li>
<li>plasma/generic/scriptengines/google_gadgets/panel_decorator.h <span \
style="color: grey">(e82d43d6a5a17c76efad00b6d0952928d5c9263d)</span></li>
<li>plasma/generic/scriptengines/google_gadgets/panel_decorator.cpp <span \
style="color: grey">(16896ae8873b1a461608004b52d7246a2a6ec69a)</span></li>
<li>plasma/generic/scriptengines/google_gadgets/plasma-applet-ggl.desktop.tmpl <span \
style="color: grey">(3ca7fce9eb665596c63ba7fe42f548e3063ffcb0)</span></li>
<li>plasma/generic/scriptengines/google_gadgets/plasma-packagestructure-googlegadgets.desktop \
<span style="color: grey">(c0436d7bbda62da45c9e06bd1c38bad12fbef808)</span></li>
<li>plasma/generic/scriptengines/google_gadgets/plasma-scriptengine-googlegadgets.desktop \
<span style="color: grey">(1633ccef39d751703ff44d0bcff86fd737e58c61)</span></li>
<li>plasma/generic/scriptengines/google_gadgets/plasma_host.h <span style="color: \
grey">(41b41362ef107759e22703d0f533e79a2f5f7d18)</span></li>
<li>plasma/generic/scriptengines/google_gadgets/plasma_host.cpp <span style="color: \
grey">(3134a47c8ce9b9ded2bf14ce96eee8a79d31ebf3)</span></li>
<li>plasma/generic/scriptengines/google_gadgets/plasma_view_host.h <span \
style="color: grey">(8c6f3abdaf21682b09686b4ec663d3dae982cfe0)</span></li>
<li>plasma/generic/scriptengines/google_gadgets/plasma_view_host.cpp <span \
style="color: grey">(cd7cb07f95f8d5bf3023f50fdac427774340e776)</span></li>
<li>plasma/generic/scriptengines/google_gadgets/plasma_view_host_internal.h <span \
style="color: grey">(ed69f657305be8d056285c9714c0e97eaaaf107a)</span></li>
<li>plasma/generic/scriptengines/google_gadgets/popout_decorator.h <span \
style="color: grey">(01a5671c73747852b89b495a6e6012d97df51cf7)</span></li>
<li>plasma/generic/scriptengines/google_gadgets/popout_decorator.cpp <span \
style="color: grey">(11d6a463a467ccf3a6810aed9d595906b67e8aac)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/109607/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic