From kde-panel-devel Fri Mar 29 15:37:08 2013 From: "Alexey Shmalko" Date: Fri, 29 Mar 2013 15:37:08 +0000 To: kde-panel-devel Subject: Re: Review Request 106110: Make autohide panel do not intercept events in fullscreen app Message-Id: <20130329153708.20284.75305 () vidsolbach ! de> X-MARC-Message: https://marc.info/?l=kde-panel-devel&m=136457145132547 MIME-Version: 1 Content-Type: multipart/mixed; boundary="--===============7368906079571134946==" --===============7368906079571134946== Content-Type: multipart/alternative; boundary="===============1183342645175601720==" --===============1183342645175601720== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106110/#review30074 ----------------------------------------------------------- Can someone from plasma please take a look at this? - Alexey Shmalko On March 22, 2013, 4:53 p.m., Alexey Shmalko wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/106110/ > ----------------------------------------------------------- > > (Updated March 22, 2013, 4:53 p.m.) > > > Review request for kwin and Plasma. > > > Description > ------- > > Make autohide panel do not intercept events in fullscreen app. > > I changed PanelView::createUnhideTrigger() to check whether current active application is in fullscreen mode. So in fullscreen applications panel will be always hidden. > > > This addresses bug 217560. > http://bugs.kde.org/show_bug.cgi?id=217560 > > > Diffs > ----- > > plasma/desktop/shell/panelview.cpp 7713740 > > Diff: http://git.reviewboard.kde.org/r/106110/diff/ > > > Testing > ------- > > Tested with patched gentoo ebuild. Works fine. > > > Thanks, > > Alexey Shmalko > > --===============1183342645175601720== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit

This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106110/

Can someone from plasma please take a look at this?

- Alexey

On March 22nd, 2013, 4:53 p.m. UTC, Alexey Shmalko wrote:

Review request for kwin and Plasma.

By Alexey Shmalko.

Updated March 22, 2013, 4:53 p.m.

Description

Make autohide panel do not intercept events in fullscreen app.

I changed PanelView::createUnhideTrigger() to check whether current active application is in fullscreen mode. So in fullscreen applications panel will be always hidden.

Testing

Tested with patched gentoo ebuild. Works fine.

Bugs: 217560

Diffs

plasma/desktop/shell/panelview.cpp (7713740)

View Diff

--===============1183342645175601720==-- --===============7368906079571134946== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel --===============7368906079571134946==--