This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109793/

Review request for Plasma, Sebastian Kügler and Shaun Reich.
By Maarten De Meyer.

Updated March 29, 2013, 2:01 p.m.

Description

Check the network connection before running the mediawiki and youtube runner. We could make it wait for a connection, now you need to change the query.
This needs solid networking.

Do I need to add a macro_log_feature for solid in the main CMakelists.txt file?
In what branch does this go if accepted? (master and frameworks?)

Testing

Compiled and run.

Diffs

  • runners/mediawiki/CMakeLists.txt (1e9a67a)
  • runners/mediawiki/mediawikirunner.cpp (91d78f3)
  • runners/youtube/CMakeLists.txt (639d403)
  • runners/youtube/youtube.cpp (a16e40b)

View Diff