'Re: Review Request 109595: active-welcome plasmoid: use plasmacomponents ToolButton'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request 109595: active-welcome plasmoid: use plasmacomponents ToolButton
From:       "Michael Bohlender" <michael.bohlender () gmail ! com>
Date:       2013-03-29 10:47:04
Message-ID: 20130329104704.4191.47802 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109595/
-----------------------------------------------------------

(Updated March 29, 2013, 10:47 a.m.)

Status
------

This change has been marked as submitted.

Review request for Plasma.

Description
-------

Replace ?mobilecomponents?.IconButton with PlasmaComponents.ToolButton

I estimated the button size. they might seem visually smaller but the surface you can \
hit to trigger should be about the same.

This is my fist patch to Plasma Active.
I did not subscribe to the plasma list when I first tried to submit this to \
reviewboard.  So sorry for the spam if this comes through twice.

Diffs
-----

  applets/active-welcome/contents/code/welcome.qml cf49d2f 

Diff: http://git.reviewboard.kde.org/r/109595/diff/

Testing
-------

build + installed with kdesrc-build. viewed with plasmoidviewer

could not test the video playback as that didn't work before either.

Thanks,

Michael Bohlender

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/109595/">http://git.reviewboard.kde.org/r/109595/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#e0e0e0" width="100%" cellpadding="8" style="border: 1px gray \
solid;">  <tr>
  <td>
   <h1 style="margin-right: 0.2em; padding: 0; font-size: 10pt;">This change has been \
marked as submitted.</h1>  </td>
 </tr>
</table>
<br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for Plasma.</div>
<div>By Michael Bohlender.</div>

<p style="color: grey;"><i>Updated March 29, 2013, 10:47 a.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Replace ?mobilecomponents?.IconButton with PlasmaComponents.ToolButton

I estimated the button size. they might seem visually smaller but the surface you can \
hit to trigger should be about the same.

This is my fist patch to Plasma Active.
I did not subscribe to the plasma list when I first tried to submit this to \
reviewboard.  So sorry for the spam if this comes through twice.</pre>
  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">build + installed with kdesrc-build. viewed with plasmoidviewer

could not test the video playback as that didn&#39;t work before either.</pre>
  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>applets/active-welcome/contents/code/welcome.qml <span style="color: \
grey">(cf49d2f)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/109595/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[prev in list] [next in list] [prev in thread] [next in thread] 