[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Review Request 109780: Enable following links/urls from the plasma notifications popup applet
From: Amín_Guzmán_Vargas <amingv () gmail ! com>
Date: 2013-03-28 20:20:51
Message-ID: 20130328202051.31401.4888 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109780/
-----------------------------------------------------------
Review request for Plasma, Davide Bettio and Marco Martin.
Description
-------
The ability to follow a link embedded in a popup notification was disabled \
with the migration to QML of the plasma notification plasmoid. This is a \
simple patch that re-enables this functionality.
Diffs
-----
plasma/generic/applets/notifications/contents/ui/LastNotificationPopup.qml \
2fa1b11 plasma/generic/applets/notifications/contents/ui/NotificationDelegate/NotificationDelegate.qml \
ed8ed99
Diff: http://git.reviewboard.kde.org/r/109780/diff/
Testing
-------
Thanks,
Amín Guzmán Vargas
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px \
#c9c399 solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/109780/">http://git.reviewboard.kde.org/r/109780/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px \
black solid;"> <tr>
<td>
<div>Review request for Plasma, Davide Bettio and Marco Martin.</div>
<div>By Amín Guzmán Vargas.</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description \
</h1> <table width="100%" bgcolor="#ffffff" cellspacing="0" \
cellpadding="10" style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">The ability to follow a link embedded in a popup notification \
was disabled with the migration to QML of the plasma notification plasmoid. \
This is a simple patch that re-enables this functionality.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> \
</h1> <ul style="margin-left: 3em; padding-left: 0;">
<li>plasma/generic/applets/notifications/contents/ui/LastNotificationPopup.qml \
<span style="color: grey">(2fa1b11)</span></li>
<li>plasma/generic/applets/notifications/contents/ui/NotificationDelegate/NotificationDelegate.qml \
<span style="color: grey">(ed8ed99)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/109780/diff/" \
style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic