From kde-panel-devel Fri Mar 29 00:10:15 2013 From: "Aleix Pol Gonzalez" Date: Fri, 29 Mar 2013 00:10:15 +0000 To: kde-panel-devel Subject: Re: Review Request 109648: Implement the implicitWidth/implicitHeight of the chat plasmoid Message-Id: <20130329001015.8143.69943 () vidsolbach ! de> X-MARC-Message: https://marc.info/?l=kde-panel-devel&m=136451585118115 MIME-Version: 1 Content-Type: multipart/mixed; boundary="--===============5284509379685125169==" --===============5284509379685125169== Content-Type: multipart/alternative; boundary="===============5957778057502821019==" --===============5957778057502821019== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109648/ ----------------------------------------------------------- (Updated March 29, 2013, 12:10 a.m.) Status ------ This change has been marked as submitted. Review request for Plasma, Telepathy and David Edmundson. Description ------- Implements those 2 properties, aliasing to the similar preferredWidth/Height. When I have Icon-Only tasks + Chat plasmoid in a panel, their growth rendered unpredictable. Implementing the implicit seems to solve this problem. Diffs ----- chat/org.kde.ktp-chat/contents/ui/main.qml e11269e Diff: http://git.reviewboard.kde.org/r/109648/diff/ Testing ------- I was reproducing the problem regularly since a couple of days, then now I cannot reproduce anymore. There's no testing per se, though... Thanks, Aleix Pol Gonzalez --===============5957778057502821019== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit

This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109648/

This change has been marked as submitted.

Review request for Plasma, Telepathy and David Edmundson.

By Aleix Pol Gonzalez.

Updated March 29, 2013, 12:10 a.m.

Description

Implements those 2 properties, aliasing to the similar preferredWidth/Height.

When I have Icon-Only tasks + Chat plasmoid in a panel, their growth rendered unpredictable. Implementing the implicit seems to solve this problem.

Testing

I was reproducing the problem regularly since a couple of days, then now I cannot reproduce anymore.

There's no testing per se, though...

Diffs

chat/org.kde.ktp-chat/contents/ui/main.qml (e11269e)

View Diff

--===============5957778057502821019==-- --===============5284509379685125169== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel --===============5284509379685125169==--