[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request 109773: New runner that translates words and sentences via Google Translate.
From: Martin_Gräßlin <mgraesslin () kde ! org>
Date: 2013-03-28 13:47:32
Message-ID: 20130328134732.4722.43718 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109773/#review30004
-----------------------------------------------------------
I'm looking forward to use this runner.
Have you thought about adding another keyword to query all supported languages?
runners/translator/translator.cpp
<http://git.reviewboard.kde.org/r/109773/#comment22369>
you are missing the > after the email address (also in the other copyright \
header)
runners/translator/translator.cpp
<http://git.reviewboard.kde.org/r/109773/#comment22370>
I would suggest to turn the logic around:
if (!ok) {
return;
}
the code following has many indentation levels and that's just one level which is \
not really needed.
runners/translator/translator.cpp
<http://git.reviewboard.kde.org/r/109773/#comment22376>
here you could do the same:
if (list0.isEmpty()) {
continue;
}
runners/translator/translator.cpp
<http://git.reviewboard.kde.org/r/109773/#comment22374>
using or is rather uncommon in KDE code. I would suggest to use ||
runners/translator/translator.cpp
<http://git.reviewboard.kde.org/r/109773/#comment22375>
same for and
runners/translator/translator.cpp
<http://git.reviewboard.kde.org/r/109773/#comment22371>
nitpick: QList<int>
runners/translator/translator.cpp
<http://git.reviewboard.kde.org/r/109773/#comment22372>
nitpick: trailing whitespaces
runners/translator/translatorjob.cpp
<http://git.reviewboard.kde.org/r/109773/#comment22373>
isn't that a rather generic user agent?
- Martin Gräßlin
On March 28, 2013, 12:14 p.m., David Baum wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/109773/
> -----------------------------------------------------------
>
> (Updated March 28, 2013, 12:14 p.m.)
>
>
> Review request for Plasma.
>
>
> Description
> -------
>
> The Runner uses the Google Translate Homepage and supports all languages provided \
> by Google. It doesn't use the API, because it's not free of charge.
>
> Diffs
> -----
>
> runners/CMakeLists.txt bb4b491b10e6fef8183a66f55f5d5832dd7bc41a
> runners/translator/CMakeLists.txt PRE-CREATION
> runners/translator/plasma-runner-translator.desktop PRE-CREATION
> runners/translator/translator.h PRE-CREATION
> runners/translator/translator.cpp PRE-CREATION
> runners/translator/translatorjob.h PRE-CREATION
> runners/translator/translatorjob.cpp PRE-CREATION
>
> Diff: http://git.reviewboard.kde.org/r/109773/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> David Baum
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/109773/">http://git.reviewboard.kde.org/r/109773/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I'm looking forward \
to use this runner.
Have you thought about adding another keyword to query all supported languages?</pre>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="http://git.reviewboard.kde.org/r/109773/diff/3/?file=125697#file125697line2" \
style="color: black; font-weight: bold; text-decoration: \
underline;">runners/translator/translator.cpp</a> <span style="font-weight: \
normal;">
(Diff revision 3)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">2</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span \
class="cm"> * Copyright (C) 2013 by David Baum <david.baum@naraesk.eu \
*</span></pre></td> </tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">you are \
missing the > after the email address (also in the other copyright header)</pre> \
</div> <br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="http://git.reviewboard.kde.org/r/109773/diff/3/?file=125697#file125697line121" \
style="color: black; font-weight: bold; text-decoration: \
underline;">runners/translator/translator.cpp</a> <span style="font-weight: \
normal;">
(Diff revision 3)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">121</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="k">if</span> <span class="p">(</span><span class="n">ok</span><span \
class="p">)</span> <span class="p">{</span></pre></td> </tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I would \
suggest to turn the logic around: if (!ok) {
return;
}
the code following has many indentation levels and that's just one level which is \
not really needed.</pre> </div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="http://git.reviewboard.kde.org/r/109773/diff/3/?file=125697#file125697line128" \
style="color: black; font-weight: bold; text-decoration: \
underline;">runners/translator/translator.cpp</a> <span style="font-weight: \
normal;">
(Diff revision 3)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">128</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> \
<span class="k">if</span> <span class="p">(</span><span class="n">list0</span><span \
class="p">.</span><span class="n">size</span><span class="p">()</span> <span \
class="o">></span> <span class="mi">0</span><span class="p">)</span> <span \
class="p">{</span></pre></td> </tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">here you \
could do the same: if (list0.isEmpty()) {
continue;
}</pre>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="http://git.reviewboard.kde.org/r/109773/diff/3/?file=125697#file125697line138" \
style="color: black; font-weight: bold; text-decoration: \
underline;">runners/translator/translator.cpp</a> <span style="font-weight: \
normal;">
(Diff revision 3)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">138</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> \
<span class="k">if</span> <span class="p">(</span><span class="n">foundWordNew</span> \
<span class="n">or</span> <span class="n">foundWordOld</span><span class="p">)</span> \
<span class="p">{</span></pre></td> </tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">using or is \
rather uncommon in KDE code. I would suggest to use ||</pre> </div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="http://git.reviewboard.kde.org/r/109773/diff/3/?file=125697#file125697line139" \
style="color: black; font-weight: bold; text-decoration: \
underline;">runners/translator/translator.cpp</a> <span style="font-weight: \
normal;">
(Diff revision 3)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">139</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> \
<span class="k">if</span> <span class="p">(</span><span class="n">l1</span><span \
class="p">.</span><span class="n">toList</span><span class="p">().</span><span \
class="n">at</span><span class="p">(</span><span class="mi">0</span><span \
class="p">).</span><span class="n">toString</span><span class="p">()</span> <span \
class="o">!=</span> <span class="n">text</span> <span class="n">and</span> <span \
class="n">foundWordOld</span><span class="p">)</span> <span \
class="p">{</span></pre></td> </tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">same for \
and</pre> </div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="http://git.reviewboard.kde.org/r/109773/diff/3/?file=125697#file125697line164" \
style="color: black; font-weight: bold; text-decoration: \
underline;">runners/translator/translator.cpp</a> <span style="font-weight: \
normal;">
(Diff revision 3)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">164</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> \
<span class="n">QList</span> <span class="o"><</span><span \
class="kt">int</span><span class="o">></span> <span class="n">keys</span> <span \
class="o">=</span> <span class="n">sentences</span><span class="p">.</span><span \
class="n">uniqueKeys</span><span class="p">();</span></pre></td> </tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">nitpick: \
QList<int></pre> </div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="http://git.reviewboard.kde.org/r/109773/diff/3/?file=125697#file125697line204" \
style="color: black; font-weight: bold; text-decoration: \
underline;">runners/translator/translator.cpp</a> <span style="font-weight: \
normal;">
(Diff revision 3)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">204</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span \
class="k">const</span> <span class="n">QStringList</span> <span \
class="n">Translator</span><span class="o">::</span><span \
class="n">supportedLanguages</span> <span class="o">=</span> <span \
class="n">QStringList</span><span class="p">()</span> <span class="o"><<</span> \
<span class="s">"af"</span> <span class="o"><<</span> <span \
class="s">"sq"</span> <span class="o"><<</span> <span \
class="s">"ar"</span> <span class="o"><<</span> <span \
class="s">"az"</span><span class="ew"> </span></pre></td> </tr>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">205</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span \
class="tb"> </span><span class="tb"> </span><span class="tb"> </span><span \
class="tb"> </span><span class="tb"> </span><span class="o"><<</span> <span \
class="s">"eu"</span> <span class="o"><<</span> <span \
class="s">"bn"</span> <span class="o"><<</span> <span \
class="s">"be"</span> <span class="o"><<</span> <span \
class="s">"bg"</span> <span class="o"><<</span> <span \
class="s">"ca"</span> <span class="o"><<</span> <span \
class="s">"zh-CN"</span> <span class="o"><<</span> <span \
class="s">"zh-TW"</span> <span class="o"><<</span> <span \
class="s">"hr"</span> <span class="o"><<</span> <span \
class="s">"cs"</span></pre></td> </tr>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">206</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span \
class="tb"> </span><span class="tb"> </span><span class="tb"> </span><span \
class="tb"> </span><span class="tb"> </span><span class="o"><<</span> <span \
class="s">"da"</span> <span class="o"><<</span> <span \
class="s">"nl"</span> <span class="o"><<</span> <span \
class="s">"en"</span> <span class="o"><<</span> <span \
class="s">"eo"</span> <span class="o"><<</span> <span \
class="s">"et"</span> <span class="o"><<</span> <span \
class="s">"tl"</span> <span class="o"><<</span> <span \
class="s">"fi"</span> <span class="o"><<</span> <span \
class="s">"fr"</span> <span class="o"><<</span> <span \
class="s">"gl"</span></pre></td> </tr>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">207</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span \
class="tb"> </span><span class="tb"> </span><span class="tb"> </span><span \
class="tb"> </span><span class="tb"> </span><span class="o"><<</span> <span \
class="s">"ka"</span> <span class="o"><<</span> <span \
class="s">"de"</span> <span class="o"><<</span> <span \
class="s">"el"</span> <span class="o"><<</span> <span \
class="s">"gu"</span> <span class="o"><<</span> <span \
class="s">"ht"</span> <span class="o"><<</span> <span \
class="s">"iw"</span> <span class="o"><<</span> <span \
class="s">"hi"</span> <span class="o"><<</span> <span \
class="s">"hu"</span> <span class="o"><<</span> <span \
class="s">"is"</span><span class="ew"> </span></pre></td> </tr>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">208</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span \
class="tb"> </span><span class="tb"> </span><span class="tb"> </span><span \
class="tb"> </span><span class="tb"> </span><span class="o"><<</span> <span \
class="s">"id"</span> <span class="o"><<</span> <span \
class="s">"ga"</span> <span class="o"><<</span> <span \
class="s">"it"</span> <span class="o"><<</span> <span \
class="s">"ja"</span> <span class="o"><<</span> <span \
class="s">"kn"</span> <span class="o"><<</span> <span \
class="s">"ko"</span> <span class="o"><<</span> <span \
class="s">"la"</span> <span class="o"><<</span> <span \
class="s">"lv"</span> <span class="o"><<</span> <span \
class="s">"lt"</span><span class="ew"> </span></pre></td> </tr>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">209</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span \
class="tb"> </span><span class="tb"> </span><span class="tb"> </span><span \
class="tb"> </span><span class="tb"> </span><span class="o"><<</span> <span \
class="s">"mk"</span> <span class="o"><<</span> <span \
class="s">"ms"</span> <span class="o"><<</span> <span \
class="s">"mt"</span> <span class="o"><<</span> <span \
class="s">"no"</span> <span class="o"><<</span> <span \
class="s">"fa"</span> <span class="o"><<</span> <span \
class="s">"pl"</span> <span class="o"><<</span> <span \
class="s">"pt"</span> <span class="o"><<</span> <span \
class="s">"ro"</span> <span class="o"><<</span> <span \
class="s">"ru"</span><span class="ew"> </span></pre></td> </tr>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">210</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span \
class="tb"> </span><span class="tb"> </span><span class="tb"> </span><span \
class="tb"> </span><span class="tb"> </span><span class="o"><<</span> <span \
class="s">"sr"</span> <span class="o"><<</span> <span \
class="s">"sk"</span> <span class="o"><<</span> <span \
class="s">"sl"</span> <span class="o"><<</span> <span \
class="s">"es"</span> <span class="o"><<</span> <span \
class="s">"sw"</span> <span class="o"><<</span> <span \
class="s">"sv"</span> <span class="o"><<</span> <span \
class="s">"ta"</span> <span class="o"><<</span> <span \
class="s">"te"</span> <span class="o"><<</span> <span \
class="s">"th"</span><span class="ew"> </span></pre></td> </tr>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">211</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span \
class="tb"> </span><span class="tb"> </span><span class="tb"> </span><span \
class="tb"> </span><span class="tb"> </span><span class="o"><<</span> <span \
class="s">"tr"</span> <span class="o"><<</span> <span \
class="s">"uk"</span> <span class="o"><<</span> <span \
class="s">"ur"</span> <span class="o"><<</span> <span \
class="s">"vi"</span> <span class="o"><<</span> <span \
class="s">"cy"</span> <span class="o"><<</span> <span \
class="s">"yi"</span><span class="p">;</span></pre></td> </tr>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">212</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span \
class="ew"><span class="tb"> </span><span class="tb"> </span></span></pre></td> \
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">nitpick: \
trailing whitespaces</pre> </div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="http://git.reviewboard.kde.org/r/109773/diff/3/?file=125699#file125699line27" \
style="color: black; font-weight: bold; text-decoration: \
underline;">runners/translator/translatorjob.cpp</a> <span style="font-weight: \
normal;">
(Diff revision 3)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">27</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span \
class="tb"> </span><span class="n">request</span><span class="p">.</span><span \
class="n">setRawHeader</span><span class="p">(</span> <span \
class="s">"User-Agent"</span> <span class="p">,</span> <span \
class="s">"Mozilla/5.0"</span><span class="p">);</span></pre></td> </tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">isn't \
that a rather generic user agent?</pre> </div>
<br />
<p>- Martin</p>
<br />
<p>On March 28th, 2013, 12:14 p.m. CET, David Baum wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Plasma.</div>
<div>By David Baum.</div>
<p style="color: grey;"><i>Updated March 28, 2013, 12:14 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">The Runner uses the Google Translate Homepage and supports all languages \
provided by Google. It doesn't use the API, because it's not free of charge. \
</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>runners/CMakeLists.txt <span style="color: \
grey">(bb4b491b10e6fef8183a66f55f5d5832dd7bc41a)</span></li>
<li>runners/translator/CMakeLists.txt <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>runners/translator/plasma-runner-translator.desktop <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>runners/translator/translator.h <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>runners/translator/translator.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>runners/translator/translatorjob.h <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>runners/translator/translatorjob.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/109773/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic