'Re: Review Request 109775: Open mediawiki runner links in default browser'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request 109775: Open mediawiki runner links in default browser
From:       Sebastian_Kügler <sebas () kde ! org>
Date:       2013-03-28 12:21:02
Message-ID: 20130328122102.27260.62203 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109775/#review29998
-----------------------------------------------------------

Ship it!

Ship It!

- Sebastian Kügler

On March 28, 2013, 11:18 a.m., Maarten De Meyer wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/109775/
> -----------------------------------------------------------
> 
> (Updated March 28, 2013, 11:18 a.m.)
> 
> 
> Review request for Plasma, Richard Moore and Sebastian Kügler.
> 
> 
> Description
> -------
> 
> Use KToolInvocation::invokeBrowser to open links. This opens in the users default \
> browser instead of konqueror. 
> Advantages: faster, opens in default browser
> Disadvantages: only works with html (otherwise use KRun), deprecated for Qt5 use \
> QDesktopServices::openUrl(url) 
> 
> Diffs
> -----
> 
> runners/mediawiki/mediawikirunner.cpp 0b6c718 
> 
> Diff: http://git.reviewboard.kde.org/r/109775/diff/
> 
> 
> Testing
> -------
> 
> Tested with wikipedia using rekonq and chrome.
> Articles open 'much' faster.
> 
> 
> Thanks,
> 
> Maarten De Meyer
> 
> 

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/109775/">http://git.reviewboard.kde.org/r/109775/</a>
  </td>
    </tr>
   </table>
   <br />

 <p>Ship it!</p>

 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Ship It!</pre>  <br />

<p>- Sebastian</p>

<br />
<p>On March 28th, 2013, 11:18 a.m. UTC, Maarten De Meyer wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for Plasma, Richard Moore and Sebastian Kügler.</div>
<div>By Maarten De Meyer.</div>

<p style="color: grey;"><i>Updated March 28, 2013, 11:18 a.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Use KToolInvocation::invokeBrowser to open links. This opens in the \
users default browser instead of konqueror.

Advantages: faster, opens in default browser
Disadvantages: only works with html (otherwise use KRun), deprecated for Qt5 use \
QDesktopServices::openUrl(url)</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Tested with wikipedia using rekonq and chrome. Articles open \
&#39;much&#39; faster.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>runners/mediawiki/mediawikirunner.cpp <span style="color: \
grey">(0b6c718)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/109775/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[prev in list] [next in list] [prev in thread] [next in thread] 