From kde-panel-devel  Wed Mar 27 21:22:57 2013
From: David Edmundson <david () davidedmundson ! co ! uk>
Date: Wed, 27 Mar 2013 21:22:57 +0000
To: kde-panel-devel
Subject: Re: [Nepomuk] Nepomukcontroller rewritten in QML
Message-Id: <CAGeFrHCPC_Okbj7g-uM0JK8aVHpkGpTcksRVFqtzscfKghpQPg () mail ! gmail ! com>
X-MARC-Message: https://marc.info/?l=kde-panel-devel&m=136441939119971

Nicely done, a few minor comments still, but a "ship it!" from me.

Applet:

Missing Messages.sh file

 This is needed to tell the translation mechanism to extract the
messages in the i18n functions
 Copy this from another existing applet.  Make sure you copy a version
from an applet that already uses QML, such as the battery applet.
 You will need to update the file that says which .pot file to save
to, this must match a specific naming scheme based on the applet name


Dataengine:

.desktop file says your license is BSD. All code says GPL.
Missing Messages.sh file as above

Migration:

Maybe this will help?
https://projects.kde.org/projects/extragear/network/telepathy/ktp-desktop-applets/repository/revisions/3103f62214852b4360527d055110c02e3d46430c
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel