--===============8356104354414379445== Content-Type: multipart/alternative; boundary="===============3857482155436563177==" --===============3857482155436563177== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109699/ ----------------------------------------------------------- (Updated March 26, 2013, 8:03 p.m.) Status ------ This change has been marked as submitted. Review request for Plasma and Telepathy. Description ------- These are some ideas I got from the last commit, let's see: * Provide a bigger minimum size, I thought it would never get to the minimum but it does sometimes, so we can better give a bigger minimum (which is still too small for a proper usage). * Rename preferredWidth/Height -> implicit*. It seems like it's the proper way to call these. * When the plasmoid is empty, offer an empty preferred (uh implicit) size. Diffs ----- chat/org.kde.ktp-chat/contents/ui/main.qml 1ee042a Diff: http://git.reviewboard.kde.org/r/109699/diff/ Testing ------- Tested it in plasma-desktop (it's very hard to test sizes with plasmoidviewer and such), I still have the Icon Tasks eating up my space, but I guess I have to debug other code to get around that. At least now it doesn't get as squeezed. Thanks, Aleix Pol Gonzalez --===============3857482155436563177== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit

This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109699/

This change has been marked as submitted.

Review request for Plasma and Telepathy.

By Aleix Pol Gonzalez.

Updated March 26, 2013, 8:03 p.m.

Description

These are some ideas I got from the last commit, let's see:
* Provide a bigger minimum size, I thought it would never get to the minimum but it does sometimes, so we can better give a bigger minimum (which is still too small for a proper usage).
* Rename preferredWidth/Height -> implicit*. It seems like it's the proper way to call these.
* When the plasmoid is empty, offer an empty preferred (uh implicit) size.

Testing

Tested it in plasma-desktop (it's very hard to test sizes with plasmoidviewer and such), I still have the Icon Tasks eating up my space, but I guess I have to debug other code to get around that. At least now it doesn't get as squeezed.

Diffs

chat/org.kde.ktp-chat/contents/ui/main.qml (1ee042a)

--===============3857482155436563177==-- --===============8356104354414379445== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel --===============8356104354414379445==--