From kde-panel-devel Tue Mar 26 20:00:04 2013 From: "Aleix Pol Gonzalez" Date: Tue, 26 Mar 2013 20:00:04 +0000 To: kde-panel-devel Subject: Re: Review Request 109712: Make it possible to use action groups with QMenuItem Message-Id: <20130326200004.5927.92917 () vidsolbach ! de> X-MARC-Message: https://marc.info/?l=kde-panel-devel&m=136432802020025 MIME-Version: 1 Content-Type: multipart/mixed; boundary="--===============8737198626276601859==" --===============8737198626276601859== Content-Type: multipart/alternative; boundary="===============0212663931708778094==" --===============0212663931708778094== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109712/ ----------------------------------------------------------- (Updated March 26, 2013, 8 p.m.) Status ------ This change has been discarded. Review request for Plasma. Description ------- Makes it possible to use the setActionGroup method. It's interesting in case we are displaying options in a menu, since this way we can offer a more appropriate UI. Diffs ----- plasma/declarativeimports/core/corebindingsplugin.cpp 169fd35 plasma/declarativeimports/plasmacomponents/qmenuitem.h 0f43418 plasma/declarativeimports/plasmacomponents/qmenuitem.cpp e8d590d Diff: http://git.reviewboard.kde.org/r/109712/diff/ Testing ------- I have some code using it locally in muon. It works fine. Thanks, Aleix Pol Gonzalez --===============0212663931708778094== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit
This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109712/

This change has been discarded.

Review request for Plasma.
By Aleix Pol Gonzalez.

Updated March 26, 2013, 8 p.m.

Description 

Makes it possible to use the setActionGroup method. It's interesting in case we are displaying options in a menu, since this way we can offer a more appropriate UI.

Testing 

I have some code using it locally in muon. It works fine.

Diffs

  • plasma/declarativeimports/core/corebindingsplugin.cpp (169fd35)
  • plasma/declarativeimports/plasmacomponents/qmenuitem.h (0f43418)
  • plasma/declarativeimports/plasmacomponents/qmenuitem.cpp (e8d590d)

View Diff
--===============0212663931708778094==-- --===============8737198626276601859== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel --===============8737198626276601859==--