'Re: Review Request 109711: Fixes a bug in the KDE dataengine to use the POST'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request 109711: Fixes a bug in the KDE dataengine to use the POST
From:       "Aaron J. Seigo" <aseigo () kde ! org>
Date:       2013-03-26 19:58:48
Message-ID: 20130326195848.5587.96779 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109711/#review29910
-----------------------------------------------------------

Ship it!

Ship It!

- Aaron J. Seigo

On March 25, 2013, 6:50 p.m., Bhaskar Kandiyal wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/109711/
> -----------------------------------------------------------
> 
> (Updated March 25, 2013, 6:50 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Description
> -------
> 
> Fixes a bug where the default text engine 'kde' fails when pasting text longer than \
> 513/741 characters in the PasteBin widget. The problem is that the generic \
> dataengine 'kde' uses a GET request to send data to the http://paste.kde.org server \
> which does not allow large text to be sent to the server. This patch changes the \
> GET request to a POST request which fixes the bug. 
> Bug Report: https://bugs.kde.org/show_bug.cgi?id=289647
> 
> 
> This addresses bug 289647.
> http://bugs.kde.org/show_bug.cgi?id=289647
> 
> 
> Diffs
> -----
> 
> plasma/generic/dataengines/share/backends/kde/contents/code/main.js 600950d 
> 
> Diff: http://git.reviewboard.kde.org/r/109711/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Bhaskar Kandiyal
> 
> 

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/109711/">http://git.reviewboard.kde.org/r/109711/</a>
  </td>
    </tr>
   </table>
   <br />

 <p>Ship it!</p>

 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Ship It!</pre>  <br />

<p>- Aaron J.</p>

<br />
<p>On March 25th, 2013, 6:50 p.m. UTC, Bhaskar Kandiyal wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for Plasma.</div>
<div>By Bhaskar Kandiyal.</div>

<p style="color: grey;"><i>Updated March 25, 2013, 6:50 p.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Fixes a bug where the default text engine &#39;kde&#39; fails when \
pasting text longer than 513/741 characters in the PasteBin widget. The problem is \
that the generic dataengine &#39;kde&#39; uses a GET request to send data to the \
http://paste.kde.org server which does not allow large text to be sent to the server. \
This patch changes the GET request to a POST request which fixes the bug.  
Bug Report: https://bugs.kde.org/show_bug.cgi?id=289647</pre>
  </td>
 </tr>
</table>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>

 <a href="http://bugs.kde.org/show_bug.cgi?id=289647">289647</a>

</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>plasma/generic/dataengines/share/backends/kde/contents/code/main.js <span \
style="color: grey">(600950d)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/109711/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[prev in list] [next in list] [prev in thread] [next in thread] 