'Re: Review Request 109608: Locking active screenlocker should end grace time'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request 109608: Locking active screenlocker should end grace time
From:       "Commit Hook" <null () kde ! org>
Date:       2013-03-25 15:34:57
Message-ID: 20130325153457.19176.13950 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109608/
-----------------------------------------------------------

(Updated March 25, 2013, 3:34 p.m.)

Status
------

This change has been marked as submitted.

Review request for Plasma.

Description
-------

Locking active screenlocker should end grace time

For example, when the screenlocker activates on idle (but is not
configured to require a password) and then powerdevil suspends the
computer and is configured to lock screen on resume.

Matches behaviour of the old screensaver code.

Diffs
-----

  ksmserver/screenlocker/ksldapp.cpp 7f2e6715f0c12baa1586e41fa8f767707c9f83c5 

Diff: http://git.reviewboard.kde.org/r/109608/diff/

Testing
-------

Test it works. Test locking with and without password required still works as \
expected. Tested that locking without password required doesn't spontaneously start \
requiring password if idle timer reset when screenlocker active.

Thanks,

Oliver Henshaw

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/109608/">http://git.reviewboard.kde.org/r/109608/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#e0e0e0" width="100%" cellpadding="8" style="border: 1px gray \
solid;">  <tr>
  <td>
   <h1 style="margin-right: 0.2em; padding: 0; font-size: 10pt;">This change has been \
marked as submitted.</h1>  </td>
 </tr>
</table>
<br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for Plasma.</div>
<div>By Oliver Henshaw.</div>

<p style="color: grey;"><i>Updated March 25, 2013, 3:34 p.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Locking active screenlocker should end grace time

For example, when the screenlocker activates on idle (but is not
configured to require a password) and then powerdevil suspends the
computer and is configured to lock screen on resume.

Matches behaviour of the old screensaver code.</pre>
  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Test it works. Test locking with and without password required still \
works as expected. Tested that locking without password required doesn&#39;t \
spontaneously start requiring password if idle timer reset when screenlocker \
active.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>ksmserver/screenlocker/ksldapp.cpp <span style="color: \
grey">(7f2e6715f0c12baa1586e41fa8f767707c9f83c5)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/109608/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[prev in list] [next in list] [prev in thread] [next in thread] 