[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request 109641: Fix border detection in Plasma dialogs
From: "Commit Hook" <null () kde ! org>
Date: 2013-03-23 16:35:34
Message-ID: 20130323163534.6230.49061 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109641/#review29762
-----------------------------------------------------------
This review has been submitted with commit a88fec10e0ef2dd73f08c6ef3c912a16cf2f85c7 \
by Aleix Pol to branch master.
- Commit Hook
On March 21, 2013, 5:41 p.m., Aleix Pol Gonzalez wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/109641/
> -----------------------------------------------------------
>
> (Updated March 21, 2013, 5:41 p.m.)
>
>
> Review request for Plasma.
>
>
> Description
> -------
>
> I had some problems with plasma dialogs borders, they appeared arbitrarily.
> After a good couple of hours of debugging, I found out that there was some really \
> weird processing of the available region.
> This patch removes this processing and uses QRegion itself to figure out if the \
> border has to be painted. It seems to work fine.
>
> Diffs
> -----
>
> plasma/dialog.cpp 038444c
>
> Diff: http://git.reviewboard.kde.org/r/109641/diff/
>
>
> Testing
> -------
>
> Played with it, together with the ktp-chat plasmoid
>
>
> Thanks,
>
> Aleix Pol Gonzalez
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/109641/">http://git.reviewboard.kde.org/r/109641/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been \
submitted with commit a88fec10e0ef2dd73f08c6ef3c912a16cf2f85c7 by Aleix Pol to branch \
master.</pre> <br />
<p>- Commit</p>
<br />
<p>On March 21st, 2013, 5:41 p.m. UTC, Aleix Pol Gonzalez wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Plasma.</div>
<div>By Aleix Pol Gonzalez.</div>
<p style="color: grey;"><i>Updated March 21, 2013, 5:41 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">I had some problems with plasma dialogs borders, they appeared \
arbitrarily. After a good couple of hours of debugging, I found out that there was \
some really weird processing of the available region.
This patch removes this processing and uses QRegion itself to figure out if the \
border has to be painted. It seems to work fine.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Played with it, together with the ktp-chat plasmoid</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>plasma/dialog.cpp <span style="color: grey">(038444c)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/109641/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic