[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request 109592: Update welcome plasmoid to PlasmaComponents buttons.
From: "Aaron J. Seigo" <aseigo () kde ! org>
Date: 2013-03-22 13:57:49
Message-ID: 20130322135749.31624.82974 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
> On March 22, 2013, 1:57 p.m., Aaron J. Seigo wrote:
> > Why was this marked as discarded?
> >
> > I don't think anyone even had a chance to review it .. did you run into a problem \
> > with the patch that caused you to discard it?
ah, nevermind.. i see the other review request now .. it was next in my queue :/
- Aaron J.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109592/#review29720
-----------------------------------------------------------
On March 19, 2013, 10:24 p.m., Michael Bohlender wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/109592/
> -----------------------------------------------------------
>
> (Updated March 19, 2013, 10:24 p.m.)
>
>
> Review request for Plasma.
>
>
> Description
> -------
>
> Replace mobilecomponets buttons with PlasmaComponents buttons.
>
>
> this is my fist post to reviewboard so i hope i did everything right :)
>
>
> Diffs
> -----
>
> applets/active-welcome/contents/code/welcome.qml cf49d2f
>
> Diff: http://git.reviewboard.kde.org/r/109592/diff/
>
>
> Testing
> -------
>
> build + installed with kdesrc-build. tested with plasmoidviewer.
>
> i could not test if it still plays the video because that didn't work for me with \
> master before. should be fine though
>
>
> Thanks,
>
> Michael Bohlender
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/109592/">http://git.reviewboard.kde.org/r/109592/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On March 22nd, 2013, 1:57 p.m. UTC, <b>Aaron J. \
Seigo</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;"> <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Why was this marked as discarded?
I don't think anyone even had a chance to review it .. did you run into a problem \
with the patch that caused you to discard it?</pre> </blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">ah, nevermind.. i see \
the other review request now .. it was next in my queue :/</pre> <br />
<p>- Aaron J.</p>
<br />
<p>On March 19th, 2013, 10:24 p.m. UTC, Michael Bohlender wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Plasma.</div>
<div>By Michael Bohlender.</div>
<p style="color: grey;"><i>Updated March 19, 2013, 10:24 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Replace mobilecomponets buttons with PlasmaComponents buttons.
this is my fist post to reviewboard so i hope i did everything right :)</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">build + installed with kdesrc-build. tested with plasmoidviewer.
i could not test if it still plays the video because that didn't work for me with \
master before. should be fine though </pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>applets/active-welcome/contents/code/welcome.qml <span style="color: \
grey">(cf49d2f)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/109592/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic