[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request 106110: Make autohide panel do not intercept events in fullscreen app
From: Thomas_Lübking <thomas.luebking () gmail ! com>
Date: 2013-03-21 18:51:20
Message-ID: 20130321185120.14147.88491 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
> On March 20, 2013, 2 p.m., Aaron J. Seigo wrote:
> > have you tested the following two use cases:
> >
> > * panel hides, a window becomes full screen at that point .. does the panel still \
> > unhide now?
> > * window becomes full screen, panel hides (and with the patch no unhide trigger \
> > is created), window goes out of full screen
> > in both cases does the panel unhide or not as expected?
> >
> > the reason i ask is that the unhide trigger is only created when a resize or move \
> > event happens, deskop reserve struts are changed, the theme changes or \
> > updatePanelGeometry is called due to screen geometry change or the panel position \
> > on screen changes. .. and i'd be surprised if those get called when a window goes \
> > into or exits full screen. So this fix would create a new bug in which the hint \
> > hide doesn't show until the panel is unhidden once after a fullscreen window \
> > shows.
> > quick tip: to ensure that mouse movements don't interfere and to simulate "things \
> > happening all at once without user interaction" usually i trigger full screen \
> > with sth like: `sleep 3; qdbus org.kde.konsole-`pidof konsole` \
> > /konsole/MainWindow_1/actions/fullscreen` which gives me 3 seconds to hide the \
> > panel before the action occurs, but without any further user input.
> > I think what probably needs to happen here is a bit more straightforward -> \
> > whenever the hide area is triggered (e.g. in the "fancy" case, the mouse \
> > approaches the trigger area) it should check to see if there is a fullscreen \
> > window on the same screen and if so .. don't do anything.
> > That said, the real solution here will be to move to the single screen edge \
> > implementation where the fancy show uses the kwin effect that Martin has written \
> > (and which looks really nice, btw, Martin :)
>
> Alexey Shmalko wrote:
> * panel hides, a window becomes full screen at that point .. does the panel still \
> unhide now? No, it doesn't.
>
> * window becomes full screen, panel hides (and with the patch no unhide trigger is \
> created), window goes out of full screen Panel unhides as it do before of these \
> operations.
> So, the panel works as expected.
>
> > > I think what probably needs to happen here is a bit more straightforward -> \
> > > whenever the hide area is triggered (e.g. in the "fancy" case, the mouse \
> > > approaches the trigger area) it should check to see if there is a fullscreen \
> > > window on the same screen and if so .. don't do anything.
>
> There still one bug. 1px-width area still intercepted by panel. If do things this \
> way, this bug will disapear. I'll do this today or tomorrow.
>
> Alexey Shmalko wrote:
> Does trigger of unhide event is PanelView::hintOrUnhide()? If so, there is already \
> such code:
> KWindowInfo activeWindow = KWindowSystem::windowInfo(KWindowSystem::activeWindow(), \
> NET::WMState); if (activeWindow.state() & NET::FullScreen) {
> return false;
> }
>
> So, this approach isn't working. Panel still intercept events.
As long as the window is there it will intercept events.
Whether it shows a panel in return is a different matter.
> On March 20, 2013, 2 p.m., Aaron J. Seigo wrote:
> > plasma/desktop/shell/panelview.cpp, line 1496
> > <http://git.reviewboard.kde.org/r/106110/diff/5/?file=120303#file120303line1496>
> >
> > Better would simply be to compare screens. If they are on the same screen -> \
> > don't interfere.
a fullscreen window can cover more than one screen (@Martin: there's even a netwm \
hint on that for xinerama ;-) What you wanted to check is whether the panel and the \
window intersect.
- Thomas
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106110/#review29551
-----------------------------------------------------------
On March 18, 2013, 6:37 p.m., Alexey Shmalko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/106110/
> -----------------------------------------------------------
>
> (Updated March 18, 2013, 6:37 p.m.)
>
>
> Review request for kwin and Plasma.
>
>
> Description
> -------
>
> Make autohide panel do not intercept events in fullscreen app.
>
> I changed PanelView::createUnhideTrigger() to check whether current active \
> application is in fullscreen mode. So in fullscreen applications panel will be \
> always hidden.
>
> This addresses bug 217560.
> http://bugs.kde.org/show_bug.cgi?id=217560
>
>
> Diffs
> -----
>
> plasma/desktop/shell/panelview.cpp 7713740
>
> Diff: http://git.reviewboard.kde.org/r/106110/diff/
>
>
> Testing
> -------
>
> Tested with patched gentoo ebuild. Works fine.
>
>
> Thanks,
>
> Alexey Shmalko
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/106110/">http://git.reviewboard.kde.org/r/106110/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On March 20th, 2013, 2 p.m. UTC, <b>Aaron J. \
Seigo</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;"> <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">have you tested the following two use cases:
* panel hides, a window becomes full screen at that point .. does the panel still \
unhide now?
* window becomes full screen, panel hides (and with the patch no unhide trigger is \
created), window goes out of full screen
in both cases does the panel unhide or not as expected?
the reason i ask is that the unhide trigger is only created when a resize or move \
event happens, deskop reserve struts are changed, the theme changes or \
updatePanelGeometry is called due to screen geometry change or the panel position on \
screen changes. .. and i'd be surprised if those get called when a window goes \
into or exits full screen. So this fix would create a new bug in which the hint hide \
doesn't show until the panel is unhidden once after a fullscreen window shows.
quick tip: to ensure that mouse movements don't interfere and to simulate \
"things happening all at once without user interaction" usually i trigger \
full screen with sth like: `sleep 3; qdbus org.kde.konsole-`pidof konsole` \
/konsole/MainWindow_1/actions/fullscreen` which gives me 3 seconds to hide the panel \
before the action occurs, but without any further user input.
I think what probably needs to happen here is a bit more straightforward -> \
whenever the hide area is triggered (e.g. in the "fancy" case, the mouse \
approaches the trigger area) it should check to see if there is a fullscreen window \
on the same screen and if so .. don't do anything.
That said, the real solution here will be to move to the single screen edge \
implementation where the fancy show uses the kwin effect that Martin has written (and \
which looks really nice, btw, Martin :)</pre> </blockquote>
<p>On March 20th, 2013, 4:27 p.m. UTC, <b>Alexey Shmalko</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">* panel hides, a window \
becomes full screen at that point .. does the panel still unhide now? No, it \
doesn't.
* window becomes full screen, panel hides (and with the patch no unhide trigger is \
created), window goes out of full screen Panel unhides as it do before of these \
operations.
So, the panel works as expected.
>> I think what probably needs to happen here is a bit more straightforward \
-> whenever the hide area is triggered (e.g. in the "fancy" case, the \
mouse approaches the trigger area) it should check to see if there is a fullscreen \
window on the same screen and if so .. don't do anything.
There still one bug. 1px-width area still intercepted by panel. If do things this \
way, this bug will disapear. I'll do this today or tomorrow. </pre>
</blockquote>
<p>On March 21st, 2013, 6:42 p.m. UTC, <b>Alexey Shmalko</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Does trigger of unhide \
event is PanelView::hintOrUnhide()? If so, there is already such code:
KWindowInfo activeWindow = \
KWindowSystem::windowInfo(KWindowSystem::activeWindow(), NET::WMState); if \
(activeWindow.state() & NET::FullScreen) { return false;
}
So, this approach isn't working. Panel still intercept events.</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">As long as the window is \
there it will intercept events. Whether it shows a panel in return is a different \
matter.</pre> <br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On March 20th, 2013, 2 p.m. UTC, <b>Aaron J. \
Seigo</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="http://git.reviewboard.kde.org/r/106110/diff/5/?file=120303#file120303line1496" \
style="color: black; font-weight: bold; text-decoration: \
underline;">plasma/desktop/shell/panelview.cpp</a> <span style="font-weight: \
normal;">
(Diff revision 5)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void \
PanelView::createUnhideTrigger()</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">1496</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="n">fancy</span> <span class="o">=</span> <span \
class="n">activeWindow</span><span class="p">.</span><span \
class="n">hasState</span><span class="p">(</span><span class="n">NET</span><span \
class="o">::</span><span class="n">FullScreen</span><span class="p">)</span> <span \
class="o">&&</span> <span class="n">geometry</span><span \
class="p">().</span><span class="n">contains</span><span class="p">(</span><span \
class="n">activeWindow</span><span class="p">.</span><span \
class="n">geometry</span><span class="p">());</span></pre></td> </tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Better would simply be \
to compare screens. If they are on the same screen -> don't interfere.</pre> \
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">a \
fullscreen window can cover more than one screen (@Martin: there's even a netwm \
hint on that for xinerama ;-) What you wanted to check is whether the panel and the \
window intersect.</pre> <br />
<p>- Thomas</p>
<br />
<p>On March 18th, 2013, 6:37 p.m. UTC, Alexey Shmalko wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for kwin and Plasma.</div>
<div>By Alexey Shmalko.</div>
<p style="color: grey;"><i>Updated March 18, 2013, 6:37 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Make autohide panel do not intercept events in fullscreen app.
I changed PanelView::createUnhideTrigger() to check whether current active \
application is in fullscreen mode. So in fullscreen applications panel will be always \
hidden.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Tested with patched gentoo ebuild. Works fine.</pre> </td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=217560">217560</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>plasma/desktop/shell/panelview.cpp <span style="color: \
grey">(7713740)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/106110/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic