'Re: Review Request 109528: port bodega-server to the new node-postgres API'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request 109528: port bodega-server to the new node-postgres API
From:       "Commit Hook" <null () kde ! org>
Date:       2013-03-20 16:10:50
Message-ID: 20130320161050.31322.80975 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109528/
-----------------------------------------------------------

(Updated March 20, 2013, 4:10 p.m.)

Status
------

This change has been marked as submitted.

Review request for Plasma.

Description
-------

This patch ports the bodega-server into the new node-postgres API,
this output which comes from the node-postgres module contains more
info about the new API

WARNING!!
pg.connect(function(err, client) { ...}) is deprecated and will be removed it v1.0.0 (very soon)
instead, use pg.connect(function(err, client, done) { ... })
automatic releasing of clients back to the pool was a mistake and will be removed
please see the following for more details:
https://github.com/brianc/node-postgres/wiki/pg
https://github.com/brianc/node-postgres/issues/227
https://github.com/brianc/node-postgres/pull/274
feel free to get in touch via github if you have questions

Diffs
-----

  server/lib/bodegadb.js d17a77e 

Diff: http://git.reviewboard.kde.org/r/109528/diff/

Testing
-------

Thanks,

Giorgos Tsiapaliokas

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/109528/">http://git.reviewboard.kde.org/r/109528/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#e0e0e0" width="100%" cellpadding="8" style="border: 1px gray \
solid;">  <tr>
  <td>
   <h1 style="margin-right: 0.2em; padding: 0; font-size: 10pt;">This change has been \
marked as submitted.</h1>  </td>
 </tr>
</table>
<br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for Plasma.</div>
<div>By Giorgos Tsiapaliokas.</div>

<p style="color: grey;"><i>Updated March 20, 2013, 4:10 p.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">This patch ports the bodega-server into the new node-postgres API, this \
output which comes from the node-postgres module contains more info about the new API

WARNING!!
pg.connect(function(err, client) { ...}) is deprecated and will be removed it v1.0.0 \
(very soon) instead, use pg.connect(function(err, client, done) { ... })
automatic releasing of clients back to the pool was a mistake and will be removed
please see the following for more details:
https://github.com/brianc/node-postgres/wiki/pg
https://github.com/brianc/node-postgres/issues/227
https://github.com/brianc/node-postgres/pull/274
feel free to get in touch via github if you have questions</pre>
  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>server/lib/bodegadb.js <span style="color: grey">(d17a77e)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/109528/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[prev in list] [next in list] [prev in thread] [next in thread] 