[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request 109495: Plasmate: Replace 0 byte images with the real ones
From: Sebastian_Kügler <sebas () kde ! org>
Date: 2013-03-15 12:10:28
Message-ID: 20130315121028.23362.48198 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109495/#review29279
-----------------------------------------------------------
Ship it!
Ship It!
- Sebastian Kügler
On March 15, 2013, 11:39 a.m., Antonis Tsiapaliokas wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/109495/
> -----------------------------------------------------------
>
> (Updated March 15, 2013, 11:39 a.m.)
>
>
> Review request for Plasma.
>
>
> Description
> -------
>
> Hello,
>
> As it is being described on the bug report. The images are empty/damaged. So we are \
> re uploading them in order to solve the issue.
>
> This addresses bug 316772.
> http://bugs.kde.org/show_bug.cgi?id=316772
>
>
> Diffs
> -----
>
> plasmate/previewer/windowswitcher/thumbnails/dolphin.png \
> e69de29bb2d1d6434b8b29ae775ad8c2e48c5391 \
> plasmate/previewer/windowswitcher/thumbnails/kmail.png \
> e69de29bb2d1d6434b8b29ae775ad8c2e48c5391 \
> plasmate/previewer/windowswitcher/thumbnails/konqueror.png \
> e69de29bb2d1d6434b8b29ae775ad8c2e48c5391 \
> plasmate/previewer/windowswitcher/thumbnails/systemsettings.png \
> e69de29bb2d1d6434b8b29ae775ad8c2e48c5391
> Diff: http://git.reviewboard.kde.org/r/109495/diff/
>
>
> Testing
> -------
>
> Reviewboard says "This is a binary file. The content cannot be displayed.", so \
> everything is fine.
>
> Thanks,
>
> Antonis Tsiapaliokas
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/109495/">http://git.reviewboard.kde.org/r/109495/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Ship It!</pre> <br />
<p>- Sebastian</p>
<br />
<p>On March 15th, 2013, 11:39 a.m. UTC, Antonis Tsiapaliokas wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Plasma.</div>
<div>By Antonis Tsiapaliokas.</div>
<p style="color: grey;"><i>Updated March 15, 2013, 11:39 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Hello,
As it is being described on the bug report. The images are empty/damaged. So we are \
re uploading them in order to solve the issue.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Reviewboard says "This is a binary file. The content cannot be \
displayed.", so everything is fine.</pre> </td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=316772">316772</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>plasmate/previewer/windowswitcher/thumbnails/dolphin.png <span style="color: \
grey">(e69de29bb2d1d6434b8b29ae775ad8c2e48c5391)</span></li>
<li>plasmate/previewer/windowswitcher/thumbnails/kmail.png <span style="color: \
grey">(e69de29bb2d1d6434b8b29ae775ad8c2e48c5391)</span></li>
<li>plasmate/previewer/windowswitcher/thumbnails/konqueror.png <span style="color: \
grey">(e69de29bb2d1d6434b8b29ae775ad8c2e48c5391)</span></li>
<li>plasmate/previewer/windowswitcher/thumbnails/systemsettings.png <span \
style="color: grey">(e69de29bb2d1d6434b8b29ae775ad8c2e48c5391)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/109495/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic