'Re: Review Request 109164: set disable black listed applications'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request 109164: set disable black listed applications
From:       "Commit Hook" <null () kde ! org>
Date:       2013-02-28 20:05:57
Message-ID: 20130228200557.7711.46004 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109164/#review28290
-----------------------------------------------------------

This review has been submitted with commit 178045eab237cf012a7ef10de1d6c2cb506c7c2c by Weng \
Xuetian on behalf of Yichao Yu to branch master.

- Commit Hook

On Feb. 26, 2013, 1:29 a.m., Yichao Yu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/109164/
> -----------------------------------------------------------
> 
> (Updated Feb. 26, 2013, 1:29 a.m.)
> 
> 
> Review request for Plasma and Ivan Čukić.
> 
> 
> Description
> -------
> 
> The blacklist application widget is not set to disabled on startup. This patch disable it \
> along with the other two related elements. (Not sure if it is better to add a private slot \
> for it.) 
> 
> Diffs
> -----
> 
> src/workspace/settings/MainConfigurationWidget.cpp b8edf64 
> 
> Diff: http://git.reviewboard.kde.org/r/109164/diff/
> 
> 
> Testing
> -------
> 
> Compiled and run. blacklist widget is correctly disabled.
> 
> 
> Thanks,
> 
> Yichao Yu
> 
> 

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
    <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/109164/">http://git.reviewboard.kde.org/r/109164/</a>
  </td>
    </tr>
   </table>
   <br />

 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; \
white-space: -o-pre-wrap; word-wrap: break-word;">This review has been submitted with commit \
178045eab237cf012a7ef10de1d6c2cb506c7c2c by Weng Xuetian on behalf of Yichao Yu to branch \
master.</pre>  <br />

<p>- Commit</p>

<br />
<p>On February 26th, 2013, 1:29 a.m. UTC, Yichao Yu wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black solid;">  <tr>
  <td>

<div>Review request for Plasma and Ivan Čukić.</div>
<div>By Yichao Yu.</div>

<p style="color: grey;"><i>Updated Feb. 26, 2013, 1:29 a.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px \
solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">The blacklist \
application widget is not set to disabled on startup. This patch disable it along with the \
other two related elements. (Not sure if it is better to add a private slot for it.)
</pre>
  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid \
#b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Compiled and run. \
blacklist widget is correctly disabled. </pre>
  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>src/workspace/settings/MainConfigurationWidget.cpp <span style="color: \
grey">(b8edf64)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/109164/diff/" style="margin-left: 3em;">View \
Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[prev in list] [next in list] [prev in thread] [next in thread] 