From kde-panel-devel Thu Feb 28 17:57:44 2013 From: Alexander Neundorf Date: Thu, 28 Feb 2013 17:57:44 +0000 To: kde-panel-devel Subject: Re: Please update extra-cmake-modules, kdelibs (and plasma-frameworks) Message-Id: <201302281857.45192.neundorf () kde ! org> X-MARC-Message: https://marc.info/?l=kde-panel-devel&m=136207420720866 On Thursday 28 February 2013, David Faure wrote: ... > ... which means it will also fail at link time, not at cmake time. > So I don't see the point in this change. I'd must rather write KF5::Solid > than ${Solid_LIBRARIES}, where I can never remember if that's LIBRARY or > LIBRARIES, and Solid or SOLID, and where such variables come from, etc. > They look like an unnecessary additional layer on top... Yes, they are an additional layer on top. For all KF5-libraries, the names are _LIBRARIES. In CMake all Xyz_WhatEver variables should always either come from a FindXyz.cmake file, from a XyzConfig.cmake file, or from a cmake script file which starts with "Xyz". I think there are only few exceptions, the KDEInstallDirs.cmake being a notable one, for convenience. Alex _______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel