'Re: Review Request 109160: do not truncate list of help options in KRunner'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request 109160: do not truncate list of help options in KRunner
From:       Sebastian_Kügler <sebas () kde ! org>
Date:       2013-02-26 13:49:28
Message-ID: 20130226134928.11590.22564 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109160/
-----------------------------------------------------------

(Updated Feb. 26, 2013, 1:49 p.m.)

Review request for Plasma.

Changes
-------

Check if m_items is smaller than maxItemsAllowed.

Description
-------

Show all help options

KRunner's resultview limits the numer of items shown to 50. This makes
sense when showing runner results, but it also cuts off the list of help
options, making it incomplete.

Suggested patch adds a parameter to ResultScene::setQueryMatches(...)
which allows overriding the behaviour, and makes setting the help
options use this.

Intended for 4.10 and master.

Diffs (updated)
-----

  krunner/interfaces/default/resultscene.cpp 514c2c8 
  krunner/interfaces/default/resultscene.h 4aa4844 
  krunner/interfaces/default/interface.cpp 505e0aa 

Diff: http://git.reviewboard.kde.org/r/109160/diff/

Testing
-------

Verified that all help options are shown. No visible side-effects.

Thanks,

Sebastian Kügler

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/109160/">http://git.reviewboard.kde.org/r/109160/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for Plasma.</div>
<div>By Sebastian Kügler.</div>

<p style="color: grey;"><i>Updated Feb. 26, 2013, 1:49 p.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Check if m_items is smaller than maxItemsAllowed.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Show all help options

KRunner&#39;s resultview limits the numer of items shown to 50. This makes
sense when showing runner results, but it also cuts off the list of help
options, making it incomplete.

Suggested patch adds a parameter to ResultScene::setQueryMatches(...)
which allows overriding the behaviour, and makes setting the help
options use this.

Intended for 4.10 and master.</pre>
  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Verified that all help options are shown. No visible side-effects.</pre> \
</td>  </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> \
(updated)</h1> <ul style="margin-left: 3em; padding-left: 0;">

 <li>krunner/interfaces/default/resultscene.cpp <span style="color: \
grey">(514c2c8)</span></li>

 <li>krunner/interfaces/default/resultscene.h <span style="color: \
grey">(4aa4844)</span></li>

 <li>krunner/interfaces/default/interface.cpp <span style="color: \
grey">(505e0aa)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/109160/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[prev in list] [next in list] [prev in thread] [next in thread] 