From kde-panel-devel Mon Feb 25 19:04:12 2013 From: "Tjaart Blignaut" Date: Mon, 25 Feb 2013 19:04:12 +0000 To: kde-panel-devel Subject: Re: Review Request 108969: Visual cleanup, slight design changes(more margins) and auto sizing of te Message-Id: <20130225190412.27095.29774 () vidsolbach ! de> X-MARC-Message: https://marc.info/?l=kde-panel-devel&m=136182251131777 MIME-Version: 1 Content-Type: multipart/mixed; boundary="--===============0907302860077135178==" --===============0907302860077135178== Content-Type: multipart/alternative; boundary="===============5235526144339065628==" --===============5235526144339065628== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108969/#review28055 ----------------------------------------------------------- Ship it! Ship It! - Tjaart Blignaut On Feb. 25, 2013, 9:02 p.m., Tjaart Blignaut wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/108969/ > ----------------------------------------------------------- > > (Updated Feb. 25, 2013, 9:02 p.m.) > > > Review request for Plasma. > > > Description > ------- > > This patch > - allows the now playing widget to automatically size text when the widget is sized. The sizing is a function of height with some of the width also causing teh text to size. > - makes the play controls slighty bigger and easier to press > - Adds some margins to all the controls > - makes the progress bar a bit fatter > - Removed the "by" and "on" text > > > Diffs > ----- > > applets/nowplaying/package/contents/ui/Controls.qml 382ccf6 > applets/nowplaying/package/contents/ui/FullLayout.qml c92f5c6 > applets/nowplaying/package/contents/ui/MetadataPanel.qml dc01be6 > > Diff: http://git.reviewboard.kde.org/r/108969/diff/ > > > Testing > ------- > > Tested with some really long tracks like "Counting bodies like sheep with the rythm of the war drum" to see if sizing would work. Tested it on 22" monitor and on 32" television. Sized it to fill each screen horizontally and fill the screen half way vertically. > > > File Attachments > ---------------- > > Before > http://git.reviewboard.kde.org/media/uploaded/files/2013/02/14/nowplaying_before.png > After > http://git.reviewboard.kde.org/media/uploaded/files/2013/02/14/nowplaying_after.png > With play controls > http://git.reviewboard.kde.org/media/uploaded/files/2013/02/18/nowplaying_after_with_widgets.png > > > Thanks, > > Tjaart Blignaut > > --===============5235526144339065628== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit

This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108969/

Ship it!

Ship It!

- Tjaart

On February 25th, 2013, 9:02 p.m. SAST, Tjaart Blignaut wrote:

Review request for Plasma.

By Tjaart Blignaut.

Updated Feb. 25, 2013, 9:02 p.m.

Description

This patch 
- allows the now playing widget to automatically size text when the widget is sized. The sizing is a function of height with some of the width also causing teh text to size.
- makes the play controls slighty bigger and easier to press
- Adds some margins to all the controls
- makes the progress bar a bit fatter
- Removed the "by" and "on" text

Testing

Tested with some really long tracks like "Counting bodies like sheep with the rythm of the war drum" to see if sizing would work. Tested it on 22" monitor and on 32" television. Sized it to fill each screen horizontally and fill the screen half way vertically.

Diffs

applets/nowplaying/package/contents/ui/Controls.qml (382ccf6)
applets/nowplaying/package/contents/ui/FullLayout.qml (c92f5c6)
applets/nowplaying/package/contents/ui/MetadataPanel.qml (dc01be6)

File Attachments

--===============5235526144339065628==-- --===============0907302860077135178== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel --===============0907302860077135178==--