'Review Request 109124: qml port currentappcontrol'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Review Request 109124: qml port currentappcontrol
From:       "Greg T" <yellowcake- () gmx ! net>
Date:       2013-02-24 11:10:38
Message-ID: 20130224111038.3195.66422 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109124/
-----------------------------------------------------------

Review request for Plasma.

Description
-------

Heya folks,
This is a qml port of the netbook applet currentappcontrol. It's ready to use, but \
not fully complete. Missing features/bugs:
- If you click on the title on the task bar, it doesn't show the kwin present windows \
effect, how to implement that? Is there interest in a 'kwin dataengine' or should I \
                go for a mixed C++/QML applet?
- there is an annoyance in the task list(present windows fallback): I can set a \
minimum height, but if I close a task and re-set the minimum height, the popup won't \
                shrink again, leaving an unpleasant empty space; plasma bug?
- the close/restore buttons don't glow on hover. I couldn't load a theme svg using \
                the IconItem. Is that possible?
- do you know how to read the size of the containment the widget is contained?

Diffs
-----

  plasma/netbook/applets/currentappcontrol/package/contents/ui/main.qml PRE-CREATION 
  plasma/netbook/applets/currentappcontrol/package/metadata.desktop PRE-CREATION 
  plasma/netbook/applets/currentappcontrol/CMakeLists.txt \
46178ce3a9351845855e9fccfbc13a9d3946fc95   CMakeLists.txt \
6084d7dd7655372506e02abe9f141b73155c5857   \
plasma/netbook/applets/currentappcontrol/package/contents/ui/Task.qml PRE-CREATION 

Diff: http://git.reviewboard.kde.org/r/109124/diff/

Testing
-------

Thanks,

Greg T

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/109124/">http://git.reviewboard.kde.org/r/109124/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for Plasma.</div>
<div>By Greg T.</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Heya folks, This is a qml port of the netbook applet currentappcontrol. \
It&#39;s ready to use, but not fully complete. Missing features/bugs:
- If you click on the title on the task bar, it doesn&#39;t show the kwin present \
windows effect, how to implement that? Is there interest in a &#39;kwin \
                dataengine&#39; or should I go for a mixed C++/QML applet?
- there is an annoyance in the task list(present windows fallback): I can set a \
minimum height, but if I close a task and re-set the minimum height, the popup \
                won&#39;t shrink again, leaving an unpleasant empty space; plasma \
                bug?
- the close/restore buttons don&#39;t glow on hover. I couldn&#39;t load a theme svg \
                using the IconItem. Is that possible?
- do you know how to read the size of the containment the widget is contained?</pre>
  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>plasma/netbook/applets/currentappcontrol/package/contents/ui/main.qml <span \
style="color: grey">(PRE-CREATION)</span></li>

 <li>plasma/netbook/applets/currentappcontrol/package/metadata.desktop <span \
style="color: grey">(PRE-CREATION)</span></li>

 <li>plasma/netbook/applets/currentappcontrol/CMakeLists.txt <span style="color: \
grey">(46178ce3a9351845855e9fccfbc13a9d3946fc95)</span></li>

 <li>CMakeLists.txt <span style="color: \
grey">(6084d7dd7655372506e02abe9f141b73155c5857)</span></li>

 <li>plasma/netbook/applets/currentappcontrol/package/contents/ui/Task.qml <span \
style="color: grey">(PRE-CREATION)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/109124/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[prev in list] [next in list] [prev in thread] [next in thread] 