'Re: Review Request 109049: Fix favicon support for chrome bookmarks on krunner'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request 109049: Fix favicon support for chrome bookmarks on krunner
From:       "Marco Gulino" <marco.gulino () gmail ! com>
Date:       2013-02-21 19:29:10
Message-ID: 20130221192910.26898.61843 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109049/
-----------------------------------------------------------

(Updated Feb. 21, 2013, 7:29 p.m.)

Review request for kde-workspace and Plasma.

Description
-------

As reported by an user ( https://bugs.kde.org/show_bug.cgi?id=305633 ), chrome \
bookmarks database changed, and favicon wasn't shown anymore (not either the default \
"star" icon). I added the functionality back, and added a safety guard for displaying \
the default icon if something similar happens again. (note: I didn't set the "bugs" \
field here, since that bug was already closed, and was about something else).

Diffs (updated)
-----

  plasma/generic/runners/bookmarks/faviconfromblob.h cff4835 
  plasma/generic/runners/bookmarks/faviconfromblob.cpp 93c720c 
  plasma/generic/runners/bookmarks/fetchsqlite.h 8b181df 
  plasma/generic/runners/bookmarks/fetchsqlite.cpp 871deff 

Diff: http://git.reviewboard.kde.org/r/109049/diff/

Testing
-------

with chrome as default browser, install the plugin, restart krunner, type "bookmarks" \
to view all bookmarks: proper favicon is shown. Removing the database query fix, but \
leaving the safety guard, and cleaning favicon cache (to have again a "broken" \
feature case), the default icon is shown.

Thanks,

Marco Gulino

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/109049/">http://git.reviewboard.kde.org/r/109049/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for kde-workspace and Plasma.</div>
<div>By Marco Gulino.</div>

<p style="color: grey;"><i>Updated Feb. 21, 2013, 7:29 p.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">As reported by an user ( https://bugs.kde.org/show_bug.cgi?id=305633 ), \
chrome bookmarks database changed, and favicon wasn&#39;t shown anymore (not either \
the default &quot;star&quot; icon). I added the functionality back, and added a \
safety guard for displaying the default icon if something similar happens again. \
(note: I didn&#39;t set the &quot;bugs&quot; field here, since that bug was already \
closed, and was about something else).</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">with chrome as default browser, install the plugin, restart krunner, \
type &quot;bookmarks&quot; to view all bookmarks: proper favicon is shown. Removing \
the database query fix, but leaving the safety guard, and cleaning favicon cache (to \
have again a &quot;broken&quot; feature case), the default icon is shown.</pre>  \
</td>  </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> \
(updated)</h1> <ul style="margin-left: 3em; padding-left: 0;">

 <li>plasma/generic/runners/bookmarks/faviconfromblob.h <span style="color: \
grey">(cff4835)</span></li>

 <li>plasma/generic/runners/bookmarks/faviconfromblob.cpp <span style="color: \
grey">(93c720c)</span></li>

 <li>plasma/generic/runners/bookmarks/fetchsqlite.h <span style="color: \
grey">(8b181df)</span></li>

 <li>plasma/generic/runners/bookmarks/fetchsqlite.cpp <span style="color: \
grey">(871deff)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/109049/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[prev in list] [next in list] [prev in thread] [next in thread] 