'Re: Review Request 109016: Remove old code triggering a spurious spacer at the bottom of the hdd mon'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request 109016: Remove old code triggering a spurious spacer at the bottom of the hdd mon
From:       "Gregorio Guidi" <gregorio.guidi () gmail ! com>
Date:       2013-02-20 21:55:04
Message-ID: 20130220215504.11612.68332 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

> On Feb. 20, 2013, 9:59 a.m., Marco Martin wrote:
> > Ship It!

I'm not a developer with commit access, can someone take care of the submission?

Thanks!

- Gregorio

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109016/#review27776
-----------------------------------------------------------

On Feb. 18, 2013, 9:41 p.m., Gregorio Guidi wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/109016/
> -----------------------------------------------------------
> 
> (Updated Feb. 18, 2013, 9:41 p.m.)
> 
> 
> Review request for Plasma, Petri Damstén and Shaun Reich.
> 
> 
> Description
> -------
> 
> The Disk Usage and Disk Usage monitoring applets (from \
> kde-workspace/plasma/generic/applets/system-monitor/) have layout problems when \
> they are resized. Specifically, with large sizes and few plots it becomes apparent \
> that there is a spurious blank space at the bottom of the applets. The problem \
> derives form these lines: 
> setTitle(i18n("Disk Space"), true);
> setTitle(i18n("Disk Activity"), true);
> 
> The "true" argument triggers some old code that adds a spacer in the layout, which \
> I guess was used to insert some space below the header, but that now has lost its \
> purpose (see http://websvn.kde.org/?view=revision&revision=816676). 
> This submission removes this code and restores proper layout for the applets.
> 
> 
> Diffs
> -----
> 
> plasma/generic/applets/system-monitor/hdd_activity.cpp bc30a33 
> plasma/generic/applets/system-monitor/applet.h f8fe437 
> plasma/generic/applets/system-monitor/applet.cpp 653eacd 
> plasma/generic/applets/system-monitor/hdd.cpp 5762d6d 
> 
> Diff: http://git.reviewboard.kde.org/r/109016/diff/
> 
> 
> Testing
> -------
> 
> Compiled and tested. Patch applies to both master and KDE/4.10.
> 
> 
> Thanks,
> 
> Gregorio Guidi
> 
> 

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/109016/">http://git.reviewboard.kde.org/r/109016/</a>
  </td>
    </tr>
   </table>
   <br />

<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;">  <p style="margin-top: 0;">On February 20th, 2013, 9:59 a.m. UTC, <b>Marco \
Martin</b> wrote:</p>  <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;">  <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Ship It!</pre>  </blockquote>

</blockquote>

<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I&#39;m not a developer \
with commit access, can someone take care of the submission?

Thanks!
</pre>
<br />

<p>- Gregorio</p>

<br />
<p>On February 18th, 2013, 9:41 p.m. UTC, Gregorio Guidi wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for Plasma, Petri Damstén and Shaun Reich.</div>
<div>By Gregorio Guidi.</div>

<p style="color: grey;"><i>Updated Feb. 18, 2013, 9:41 p.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">The Disk Usage and Disk Usage monitoring applets (from \
kde-workspace/plasma/generic/applets/system-monitor/) have layout problems when they \
are resized. Specifically, with large sizes and few plots it becomes apparent that \
there is a spurious blank space at the bottom of the applets. The problem derives \
form these lines:

setTitle(i18n(&quot;Disk Space&quot;), true);
setTitle(i18n(&quot;Disk Activity&quot;), true);

The &quot;true&quot; argument triggers some old code that adds a spacer in the \
layout, which I guess was used to insert some space below the header, but that now \
has lost its purpose (see http://websvn.kde.org/?view=revision&amp;revision=816676).

This submission removes this code and restores proper layout for the applets.</pre>
  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Compiled and tested. Patch applies to both master and KDE/4.10.</pre>  \
</td>  </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>plasma/generic/applets/system-monitor/hdd_activity.cpp <span style="color: \
grey">(bc30a33)</span></li>

 <li>plasma/generic/applets/system-monitor/applet.h <span style="color: \
grey">(f8fe437)</span></li>

 <li>plasma/generic/applets/system-monitor/applet.cpp <span style="color: \
grey">(653eacd)</span></li>

 <li>plasma/generic/applets/system-monitor/hdd.cpp <span style="color: \
grey">(5762d6d)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/109016/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[prev in list] [next in list] [prev in thread] [next in thread] 