[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request 108969: Visual cleanup, slight design changes(more margins) and auto sizing of te
From: "Kai Uwe Broulik" <kde () privat ! broulik ! de>
Date: 2013-02-18 18:51:05
Message-ID: 20130218185105.30929.59965 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
> On Feb. 15, 2013, 12:07 a.m., Kai Uwe Broulik wrote:
> > applets/nowplaying/package/contents/ui/Controls.qml, line 27
> > <http://git.reviewboard.kde.org/r/108969/diff/1/?file=114046#file114046line27>
> >
> > You might want to make this adjust to font dpi settings or global icon sizes.
>
> Tjaart Blignaut wrote:
> I'm not sure where to look for a solution to this. Can you give me a hint of where \
> to find the functions in qml to get the standard icon sizes?
Have a look at KIconLoader IconSize() \
http://api.kde.org/4.10-api/kdelibs-apidocs/kdeui/html/classKIconLoader.html You can \
access these sizes using theme.iconSizes, see [kde-runtime] \
plasma/declarativeimports/core/theme.h for available properties. I guess when default \
button size is 40, you want to use theme.iconSizes.dialog which is the default size \
for icons in dialogs and defaults to 32x32 px.
- Kai Uwe
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108969/#review27493
-----------------------------------------------------------
On Feb. 18, 2013, 6:45 p.m., Tjaart Blignaut wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/108969/
> -----------------------------------------------------------
>
> (Updated Feb. 18, 2013, 6:45 p.m.)
>
>
> Review request for Plasma.
>
>
> Description
> -------
>
> This patch
> - allows the now playing widget to automatically size text when the widget is \
> sized. The sizing is a function of height with some of the width also causing teh \
> text to size.
> - makes the play controls slighty bigger and easier to press
> - Adds some margins to all the controls
> - makes the progress bar a bit fatter
> - Removed the "by" and "on" text
>
>
> Diffs
> -----
>
> applets/nowplaying/package/contents/ui/Controls.qml 382ccf6
> applets/nowplaying/package/contents/ui/FullLayout.qml c92f5c6
>
> Diff: http://git.reviewboard.kde.org/r/108969/diff/
>
>
> Testing
> -------
>
> Tested with some really long tracks like "Counting bodies like sheep with the rythm \
> of the war drum" to see if sizing would work. Tested it on 22" monitor and on 32" \
> television. Sized it to fill each screen horizontally and fill the screen half way \
> vertically.
>
> File Attachments
> ----------------
>
> Before
> http://git.reviewboard.kde.org/media/uploaded/files/2013/02/14/nowplaying_before.png
> After
> http://git.reviewboard.kde.org/media/uploaded/files/2013/02/14/nowplaying_after.png
> With play controls
> http://git.reviewboard.kde.org/media/uploaded/files/2013/02/18/nowplaying_after_with_widgets.png
>
>
> Thanks,
>
> Tjaart Blignaut
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/108969/">http://git.reviewboard.kde.org/r/108969/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On February 15th, 2013, 12:07 a.m. UTC, <b>Kai Uwe \
Broulik</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="http://git.reviewboard.kde.org/r/108969/diff/1/?file=114046#file114046line27" \
style="color: black; font-weight: bold; text-decoration: \
underline;">applets/nowplaying/package/contents/ui/Controls.qml</a> <span \
style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">27</font></th> <td bgcolor="#fdfebc" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">27</font></th> <td bgcolor="#fdfebc" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="nx">property</span> <span class="kr">int</span> <span \
class="k">controlSize:</span> <span class="mi">40</span><span \
class="p">;</span></pre></td> </tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">You might want to make \
this adjust to font dpi settings or global icon sizes.</pre> </blockquote>
<p>On February 18th, 2013, 6:35 p.m. UTC, <b>Tjaart Blignaut</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I'm not sure where \
to look for a solution to this. Can you give me a hint of where to find the functions \
in qml to get the standard icon sizes?</pre> </blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Have a look \
at KIconLoader IconSize() \
http://api.kde.org/4.10-api/kdelibs-apidocs/kdeui/html/classKIconLoader.html You can \
access these sizes using theme.iconSizes, see [kde-runtime] \
plasma/declarativeimports/core/theme.h for available properties. I guess when default \
button size is 40, you want to use theme.iconSizes.dialog which is the default size \
for icons in dialogs and defaults to 32x32 px.</pre> <br />
<p>- Kai Uwe</p>
<br />
<p>On February 18th, 2013, 6:45 p.m. UTC, Tjaart Blignaut wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Plasma.</div>
<div>By Tjaart Blignaut.</div>
<p style="color: grey;"><i>Updated Feb. 18, 2013, 6:45 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">This patch
- allows the now playing widget to automatically size text when the widget is sized. \
The sizing is a function of height with some of the width also causing teh text to \
size.
- makes the play controls slighty bigger and easier to press
- Adds some margins to all the controls
- makes the progress bar a bit fatter
- Removed the "by" and "on" text
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Tested with some really long tracks like "Counting bodies like \
sheep with the rythm of the war drum" to see if sizing would work. Tested it on \
22" monitor and on 32" television. Sized it to fill each screen \
horizontally and fill the screen half way vertically.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>applets/nowplaying/package/contents/ui/Controls.qml <span style="color: \
grey">(382ccf6)</span></li>
<li>applets/nowplaying/package/contents/ui/FullLayout.qml <span style="color: \
grey">(c92f5c6)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/108969/diff/" style="margin-left: \
3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments \
</h1>
<ul>
<li><a href="http://git.reviewboard.kde.org/media/uploaded/files/2013/02/14/nowplaying_before.png">Before</a></li>
<li><a href="http://git.reviewboard.kde.org/media/uploaded/files/2013/02/14/nowplaying_after.png">After</a></li>
<li><a href="http://git.reviewboard.kde.org/media/uploaded/files/2013/02/18/nowplaying_after_with_widgets.png">With \
play controls</a></li>
</ul>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic