--===============4770315893268467616== Content-Type: multipart/alternative; boundary="===============4208931843971157565==" --===============4208931843971157565== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108922/#review27631 ----------------------------------------------------------- This review has been submitted with commit 18942aeff1c78f8307f4370d3a2c5696abda7c86 by Aurélien Gâteau to branch KDE/4.10. - Commit Hook On Feb. 12, 2013, 3:10 p.m., Aurélien Gâteau wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/108922/ > ----------------------------------------------------------- > > (Updated Feb. 12, 2013, 3:10 p.m.) > > > Review request for Plasma and Aaron J. Seigo. > > > Description > ------- > > Fix off-by-one error in RunnerModel > > The last argument of beginInsertRows() is the row number of the last > inserted row, not the one for the row after. > > > Diffs > ----- > > plasma/declarativeimports/core/runnermodel.cpp ee1b54d45e02f1db8650219e08f6950d0e732a85 > > Diff: http://git.reviewboard.kde.org/r/108922/diff/ > > > Testing > ------- > > > Thanks, > > Aurélien Gâteau > > --===============4208931843971157565== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit
This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108922/ 

This review has been submitted with commit 18942aeff1c78f8307f4370d3a2c5696abda7c86 by Aurélien Gâteau to branch KDE/4.10.

- Commit


On February 12th, 2013, 3:10 p.m. UTC, Aurélien Gâteau wrote:

Review request for Plasma and Aaron J. Seigo.
By Aurélien Gâteau.

Updated Feb. 12, 2013, 3:10 p.m.

Description 

Fix off-by-one error in RunnerModel

The last argument of beginInsertRows() is the row number of the last
inserted row, not the one for the row after.

Diffs

  • plasma/declarativeimports/core/runnermodel.cpp (ee1b54d45e02f1db8650219e08f6950d0e732a85)

View Diff
--===============4208931843971157565==-- --===============4770315893268467616== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel --===============4770315893268467616==--