'Re: Review Request 108969: Visual cleanup, slight design changes(more margins) and auto sizing of te'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request 108969: Visual cleanup, slight design changes(more margins) and auto sizing of te
From:       "Tjaart Blignaut" <tjaartblig () gmail ! com>
Date:       2013-02-15 15:23:47
Message-ID: 20130215152347.18215.70524 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108969/
-----------------------------------------------------------

(Updated Feb. 15, 2013, 5:23 p.m.)

Review request for Plasma.

Changes
-------

Fixed all the whitespace and stuff that was left commented.

Description
-------

This patch 
- allows the now playing widget to automatically size text when the widget is sized. \
The sizing is a function of height with some of the width also causing teh text to \
                size.
- makes the play controls slighty bigger and easier to press
- Adds some margins to all the controls
- makes the progress bar a bit fatter
- Removed the "by" and "on" text

Diffs
-----

  applets/nowplaying/package/contents/ui/Controls.qml 382ccf6 
  applets/nowplaying/package/contents/ui/FullLayout.qml c92f5c6 

Diff: http://git.reviewboard.kde.org/r/108969/diff/

Testing
-------

Tested with some really long tracks like "Counting bodies like sheep with the rythm \
of the war drum" to see if sizing would work. Tested it on 22" monitor and on 32" \
television. Sized it to fill each screen horizontally and fill the screen half way \
vertically.

File Attachments
----------------

Before
  http://git.reviewboard.kde.org/media/uploaded/files/2013/02/14/nowplaying_before.png
 After
  http://git.reviewboard.kde.org/media/uploaded/files/2013/02/14/nowplaying_after.png

Thanks,

Tjaart Blignaut

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/108969/">http://git.reviewboard.kde.org/r/108969/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for Plasma.</div>
<div>By Tjaart Blignaut.</div>

<p style="color: grey;"><i>Updated Feb. 15, 2013, 5:23 p.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Fixed all the whitespace and stuff that was left commented.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
                break-word;">This patch 
- allows the now playing widget to automatically size text when the widget is sized. \
The sizing is a function of height with some of the width also causing teh text to \
                size.
- makes the play controls slighty bigger and easier to press
- Adds some margins to all the controls
- makes the progress bar a bit fatter
- Removed the &quot;by&quot; and &quot;on&quot; text
</pre>
  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Tested with some really long tracks like &quot;Counting bodies like \
sheep with the rythm of the war drum&quot; to see if sizing would work. Tested it on \
22&quot; monitor and on 32&quot; television. Sized it to fill each screen \
horizontally and fill the screen half way vertically.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>applets/nowplaying/package/contents/ui/Controls.qml <span style="color: \
grey">(382ccf6)</span></li>

 <li>applets/nowplaying/package/contents/ui/FullLayout.qml <span style="color: \
grey">(c92f5c6)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/108969/diff/" style="margin-left: \
3em;">View Diff</a></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments \
</h1>

<ul>

 <li><a href="http://git.reviewboard.kde.org/media/uploaded/files/2013/02/14/nowplaying_before.png">Before</a></li>

 <li><a href="http://git.reviewboard.kde.org/media/uploaded/files/2013/02/14/nowplaying_after.png">After</a></li>

</ul>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[prev in list] [next in list] [prev in thread] [next in thread] 