[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request 108944: Use custom event in konsolepreviewer
From: "Commit Hook" <null () kde ! org>
Date: 2013-02-14 11:28:29
Message-ID: 20130214112829.32450.73870 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108944/#review27436
-----------------------------------------------------------
This review has been submitted with commit d8902e8732263499f394c0f992c8e5659cbc6448 \
by Giorgos Tsiapaliokas to branch plasmate/1.0.
- Commit Hook
On Feb. 13, 2013, 2:43 p.m., Giorgos Tsiapaliokas wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/108944/
> -----------------------------------------------------------
>
> (Updated Feb. 13, 2013, 2:43 p.m.)
>
>
> Review request for Plasma.
>
>
> Description
> -------
>
> This patch adds a custom event in konsolepreviewer in order to take the output
> differently from the qInstallMsgHandler.
>
> My code is in the branch terietor/konsole/event, but I will make a new commit,
> since the commits doesn't offer any valuable information and I would like to keep
> a change like this together in one commit
>
>
> This addresses bugs 314653 and 314656.
> http://bugs.kde.org/show_bug.cgi?id=314653
> http://bugs.kde.org/show_bug.cgi?id=314656
>
>
> Diffs
> -----
>
> plasmate/konsole/konsolepreviewer.h 8dd4369
> plasmate/konsole/konsolepreviewer.cpp 7e180cb
> plasmate/main.cpp 56c9872
> plasmate/mainwindow.h 4daaaea
> plasmate/mainwindow.cpp 7a96925
>
> Diff: http://git.reviewboard.kde.org/r/108944/diff/
>
>
> Testing
> -------
>
> No crashes
>
>
> Thanks,
>
> Giorgos Tsiapaliokas
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/108944/">http://git.reviewboard.kde.org/r/108944/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been \
submitted with commit d8902e8732263499f394c0f992c8e5659cbc6448 by Giorgos \
Tsiapaliokas to branch plasmate/1.0.</pre> <br />
<p>- Commit</p>
<br />
<p>On February 13th, 2013, 2:43 p.m. UTC, Giorgos Tsiapaliokas wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Plasma.</div>
<div>By Giorgos Tsiapaliokas.</div>
<p style="color: grey;"><i>Updated Feb. 13, 2013, 2:43 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">This patch adds a custom event in konsolepreviewer in order to take the \
output differently from the qInstallMsgHandler.
My code is in the branch terietor/konsole/event, but I will make a new commit,
since the commits doesn't offer any valuable information and I would like to keep
a change like this together in one commit</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">No crashes</pre> </td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=314653">314653</a>,
<a href="http://bugs.kde.org/show_bug.cgi?id=314656">314656</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>plasmate/konsole/konsolepreviewer.h <span style="color: \
grey">(8dd4369)</span></li>
<li>plasmate/konsole/konsolepreviewer.cpp <span style="color: \
grey">(7e180cb)</span></li>
<li>plasmate/main.cpp <span style="color: grey">(56c9872)</span></li>
<li>plasmate/mainwindow.h <span style="color: grey">(4daaaea)</span></li>
<li>plasmate/mainwindow.cpp <span style="color: grey">(7a96925)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/108944/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic