[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request 104281: Drop Decorations B2, Laptop and Plastik
From: Martin_Gräßlin <mgraesslin () kde ! org>
Date: 2013-02-12 21:14:04
Message-ID: 20130212211404.31306.30255 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
> On Feb. 7, 2013, 10:25 p.m., Albert Astals Cid wrote:
> > I see this has a ship it but marked as uncommited. Was it commited and you forgot \
> > to close the request or is still uncommited?
>
> Aaron J. Seigo wrote:
> plastik is gone, but b2 and laptop are still there.
>
> Albert Astals Cid wrote:
> Is anyone planning to take care of that removal? Martin? Thomas?
>
> Thomas Lübking wrote:
> Regarding the bug reports about "plastik became slow" i'd say such movement (at \
> least for Laptop) is only possible along the introduction of a maintained legacy \
> decoration. I sent a round an RFC reg. a deco for low (network) overhead and \
> maximum usability (so we've a "failsafe" decoration for ppl. with bad eys or weird \
> network setups with the WM remote) but got no comment on that (needs input from \
> a11y and HIG and possibly a veto from the oxygen team)
> Martin Gräßlin wrote:
> As Thomas wrote: it's blocked by waiting for a (maintained) legacy decoration. The \
> decorations need to go (B2 is intercepting XEvents, Laptop is just broken), but \
> they are currently our only chance to offer something useable for remote users (not \
> that I would say it's a valid use case in 2013).
> Aaron J. Seigo wrote:
> i don't know how long ago the RFC for this replacement deco went out, so perhaps \
> this is not the case, but ... -> if you are not getting feedback from a11y/HIG, \
> please don't let that hold up such changes. it's best to get that feedback, but if \
> there is simply no feedback after a reasonable amount of time and a couple tries (2 \
> times in 6 months is pretty forgiving, imho) then my vote would be to simply push \
> forward and do your best.
> Martin Gräßlin wrote:
> I really don't want to break the last bit of remote setups. The users are already \
> angry enough with us for removing the drawbound while moving.
> So the decorations have to stay till there is a decoration for remote setups, which \
> obviously needs someone to write it.
> Albert Astals Cid wrote:
> So maybe discard the review request for now?
given that it wouldn't apply anyway - yeah.
- Martin
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104281/#review26898
-----------------------------------------------------------
On March 29, 2012, 11:27 a.m., Martin Gräßlin wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104281/
> -----------------------------------------------------------
>
> (Updated March 29, 2012, 11:27 a.m.)
>
>
> Review request for kwin and Plasma.
>
>
> Description
> -------
>
> As discussed on mailinglist: http://lists.kde.org/?l=kwin&m=133136239707091&w=2
>
>
> Diffs
> -----
>
> kwin/clients/CMakeLists.txt 6019a9e
> kwin/clients/b2/CMakeLists.txt 9295cbe
> kwin/clients/b2/b2.desktop 2846e39
> kwin/clients/b2/b2client.h c9e9b57
> kwin/clients/b2/b2client.cpp 6b52996
> kwin/clients/b2/bitmaps.h 00c4552
> kwin/clients/b2/config/CMakeLists.txt 1aaf8da
> kwin/clients/b2/config/config.h c5bc33c
> kwin/clients/b2/config/config.cpp fc9c7b9
> kwin/clients/laptop/CMakeLists.txt 1f4d600
> kwin/clients/laptop/laptop.desktop ccc9d54
> kwin/clients/laptop/laptopclient.h 4f1196d
> kwin/clients/laptop/laptopclient.cpp 52efcd1
> kwin/clients/plastik/CMakeLists.txt fce0829
> kwin/clients/plastik/config/CMakeLists.txt e48955d
> kwin/clients/plastik/config/config.h b037efe
> kwin/clients/plastik/config/config.cpp a4ddfe0
> kwin/clients/plastik/config/configdialog.ui fe9f53a
> kwin/clients/plastik/plastik.h ae7a46e
> kwin/clients/plastik/plastik.cpp ff9825f
> kwin/clients/plastik/plastik.desktop 30550c6
> kwin/clients/plastik/plastikbutton.h 395f628
> kwin/clients/plastik/plastikbutton.cpp db29d76
> kwin/clients/plastik/plastikclient.h 4c5b0d9
> kwin/clients/plastik/plastikclient.cpp 58f8324
>
> Diff: http://git.reviewboard.kde.org/r/104281/diff/
>
>
> Testing
> -------
>
> it compiles
>
>
> Thanks,
>
> Martin Gräßlin
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/104281/">http://git.reviewboard.kde.org/r/104281/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On February 7th, 2013, 10:25 p.m. CET, <b>Albert \
Astals Cid</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px \
solid #d0d0d0; padding-left: 10px;"> <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">I see this has a ship it but marked as uncommited. Was it commited and \
you forgot to close the request or is still uncommited?</pre> </blockquote>
<p>On February 8th, 2013, 5:42 p.m. CET, <b>Aaron J. Seigo</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">plastik is gone, but b2 \
and laptop are still there.</pre> </blockquote>
<p>On February 9th, 2013, 5:27 p.m. CET, <b>Albert Astals Cid</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Is anyone planning to \
take care of that removal? Martin? Thomas?</pre> </blockquote>
<p>On February 9th, 2013, 6:43 p.m. CET, <b>Thomas Lübking</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Regarding the bug \
reports about "plastik became slow" i'd say such movement (at least for \
Laptop) is only possible along the introduction of a maintained legacy decoration. I \
sent a round an RFC reg. a deco for low (network) overhead and maximum usability (so \
we've a "failsafe" decoration for ppl. with bad eys or weird network \
setups with the WM remote) but got no comment on that (needs input from a11y and HIG \
and possibly a veto from the oxygen team)</pre> </blockquote>
<p>On February 11th, 2013, 8:22 a.m. CET, <b>Martin Gräßlin</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">As Thomas wrote: \
it's blocked by waiting for a (maintained) legacy decoration. The decorations \
need to go (B2 is intercepting XEvents, Laptop is just broken), but they are \
currently our only chance to offer something useable for remote users (not that I \
would say it's a valid use case in 2013).</pre> </blockquote>
<p>On February 12th, 2013, 12:55 p.m. CET, <b>Aaron J. Seigo</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">i don't know how \
long ago the RFC for this replacement deco went out, so perhaps this is not the case, \
but ... -> if you are not getting feedback from a11y/HIG, please don't let \
that hold up such changes. it's best to get that feedback, but if there is simply \
no feedback after a reasonable amount of time and a couple tries (2 times in 6 months \
is pretty forgiving, imho) then my vote would be to simply push forward and do your \
best.</pre> </blockquote>
<p>On February 12th, 2013, 1 p.m. CET, <b>Martin Gräßlin</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I really don't want \
to break the last bit of remote setups. The users are already angry enough with us \
for removing the drawbound while moving.
So the decorations have to stay till there is a decoration for remote setups, which \
obviously needs someone to write it. </pre> </blockquote>
<p>On February 12th, 2013, 10:11 p.m. CET, <b>Albert Astals Cid</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">So maybe discard the \
review request for now?</pre> </blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">given that it \
wouldn't apply anyway - yeah.</pre> <br />
<p>- Martin</p>
<br />
<p>On March 29th, 2012, 11:27 a.m. CEST, Martin Gräßlin wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for kwin and Plasma.</div>
<div>By Martin Gräßlin.</div>
<p style="color: grey;"><i>Updated March 29, 2012, 11:27 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">As discussed on mailinglist: \
http://lists.kde.org/?l=kwin&m=133136239707091&w=2</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">it compiles</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kwin/clients/CMakeLists.txt <span style="color: grey">(6019a9e)</span></li>
<li>kwin/clients/b2/CMakeLists.txt <span style="color: grey">(9295cbe)</span></li>
<li>kwin/clients/b2/b2.desktop <span style="color: grey">(2846e39)</span></li>
<li>kwin/clients/b2/b2client.h <span style="color: grey">(c9e9b57)</span></li>
<li>kwin/clients/b2/b2client.cpp <span style="color: grey">(6b52996)</span></li>
<li>kwin/clients/b2/bitmaps.h <span style="color: grey">(00c4552)</span></li>
<li>kwin/clients/b2/config/CMakeLists.txt <span style="color: \
grey">(1aaf8da)</span></li>
<li>kwin/clients/b2/config/config.h <span style="color: grey">(c5bc33c)</span></li>
<li>kwin/clients/b2/config/config.cpp <span style="color: \
grey">(fc9c7b9)</span></li>
<li>kwin/clients/laptop/CMakeLists.txt <span style="color: \
grey">(1f4d600)</span></li>
<li>kwin/clients/laptop/laptop.desktop <span style="color: \
grey">(ccc9d54)</span></li>
<li>kwin/clients/laptop/laptopclient.h <span style="color: \
grey">(4f1196d)</span></li>
<li>kwin/clients/laptop/laptopclient.cpp <span style="color: \
grey">(52efcd1)</span></li>
<li>kwin/clients/plastik/CMakeLists.txt <span style="color: \
grey">(fce0829)</span></li>
<li>kwin/clients/plastik/config/CMakeLists.txt <span style="color: \
grey">(e48955d)</span></li>
<li>kwin/clients/plastik/config/config.h <span style="color: \
grey">(b037efe)</span></li>
<li>kwin/clients/plastik/config/config.cpp <span style="color: \
grey">(a4ddfe0)</span></li>
<li>kwin/clients/plastik/config/configdialog.ui <span style="color: \
grey">(fe9f53a)</span></li>
<li>kwin/clients/plastik/plastik.h <span style="color: grey">(ae7a46e)</span></li>
<li>kwin/clients/plastik/plastik.cpp <span style="color: grey">(ff9825f)</span></li>
<li>kwin/clients/plastik/plastik.desktop <span style="color: \
grey">(30550c6)</span></li>
<li>kwin/clients/plastik/plastikbutton.h <span style="color: \
grey">(395f628)</span></li>
<li>kwin/clients/plastik/plastikbutton.cpp <span style="color: \
grey">(db29d76)</span></li>
<li>kwin/clients/plastik/plastikclient.h <span style="color: \
grey">(4c5b0d9)</span></li>
<li>kwin/clients/plastik/plastikclient.cpp <span style="color: \
grey">(58f8324)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/104281/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic