'Re: Review Request 106118: Plasmate: Add KWin Scripting support to konsolepreviewer.'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request 106118: Plasmate: Add KWin Scripting support to konsolepreviewer.
From:       "Antonis Tsiapaliokas" <kok3rs () gmail ! com>
Date:       2013-02-12 12:26:29
Message-ID: 20130212122629.3664.33257 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106118/
-----------------------------------------------------------

(Updated Feb. 12, 2013, 12:26 p.m.)

Review request for kwin, Plasma, Martin Gräßlin, Sebastian Kügler, and Giorgos \
Tsiapaliokas.

Changes
-------

In the previous i found some regressions.

1)Sometimes the konsolepreviewer didn't return an output because it couldn't found \
the /var/kde-user/plasmatepreviewerlog.txt 2)Sometimes when you open a Plasma/Applet \
package and then a KWin/Script package or in reverse order, then the UI of the \
konsolepreviewer, was the one from the previous package.

All the above issues have been fixed.

Description
-------

Hello,

This patch is adding the konsolepreviewer support to the KWin Scripts.
When the user, is pressing the "Execute" button, then the script is being called.
Also on the toolbar, there is a new action with name "konsole". This action is \
visible only when we are inside to a KWin Script. All the other packages, have a \
previewer. So the "konsole" action is located inside the previewer.

Diffs (updated)
-----

  plasmate/konsole/konsolepreviewer.h 8dd4369 
  plasmate/konsole/konsolepreviewer.cpp 7e180cb 
  plasmate/mainwindow.h 4daaaea 
  plasmate/mainwindow.cpp 7a96925 

Diff: http://git.reviewboard.kde.org/r/106118/diff/

Testing
-------

Screenshots
-----------

konsole
  http://git.reviewboard.kde.org/r/106118/s/693/

Thanks,

Antonis Tsiapaliokas

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/106118/">http://git.reviewboard.kde.org/r/106118/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for kwin, Plasma, Martin Gräßlin, Sebastian Kügler, and \
Giorgos Tsiapaliokas.</div> <div>By Antonis Tsiapaliokas.</div>

<p style="color: grey;"><i>Updated Feb. 12, 2013, 12:26 p.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">In the previous i found some regressions.

1)Sometimes the konsolepreviewer didn&#39;t return an output because it couldn&#39;t \
found the /var/kde-user/plasmatepreviewerlog.txt 2)Sometimes when you open a \
Plasma/Applet package and then a KWin/Script package or in reverse order, then the UI \
of the konsolepreviewer, was the one from the previous package.

All the above issues have been fixed.</pre>
  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Hello,

This patch is adding the konsolepreviewer support to the KWin Scripts.
When the user, is pressing the &quot;Execute&quot; button, then the script is being \
called. Also on the toolbar, there is a new action with name &quot;konsole&quot;. \
This action is visible only when we are inside to a KWin Script. All the other \
packages, have a previewer. So the &quot;konsole&quot; action is located inside the \
previewer.

</pre>
  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> \
(updated)</h1> <ul style="margin-left: 3em; padding-left: 0;">

 <li>plasmate/konsole/konsolepreviewer.h <span style="color: \
grey">(8dd4369)</span></li>

 <li>plasmate/konsole/konsolepreviewer.cpp <span style="color: \
grey">(7e180cb)</span></li>

 <li>plasmate/mainwindow.h <span style="color: grey">(4daaaea)</span></li>

 <li>plasmate/mainwindow.cpp <span style="color: grey">(7a96925)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/106118/diff/" style="margin-left: \
3em;">View Diff</a></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Screenshots </h1>

<div>

 <a href="http://git.reviewboard.kde.org/r/106118/s/693/"><img \
src="http://git.reviewboard.kde.org/media/uploaded/images/2012/08/22/kwin_script_konsole_previewer_400x100.png" \
style="border: 1px black solid;" alt="konsole" /></a>

</div>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[prev in list] [next in list] [prev in thread] [next in thread] 