[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request 108223: use Plasma::Dialog for kmix osd
From: "Kai Uwe Broulik" <kde () privat ! broulik ! de>
Date: 2013-02-12 12:07:20
Message-ID: 20130212120720.1154.44907 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
> On Feb. 10, 2013, 10:04 a.m., Christian Esken wrote:
> > Just got a bug report that is likely realted to this change ("started happening \
> > on kde 4.10"): Bug 314803 - OSD glitches out and freezes \
> > https://bugs.kde.org/show_bug.cgi?id=314803
>
> Aaron J. Seigo wrote:
> what leads you believe it is related to this change?
>
> i've noticed that problem as well, though i believe it was well before this got \
> merged in.
> what i find happens is that if i press and hold the volume up/down button, the OSD \
> will jump and then go back and jump again .. and sometimes eventually just freeze. \
> so if it starts at 50% and i press and hold it will go 55, 60, 70, 55, 80, 60, 65, \
> 70, 75, 80, 85 ... i don't see how that has anything to do with this patch?
> also, when it freezes, sometimes (perhaps always, but i can't say for sure) even \
> the kmix icon in the systemtray (which remains otherwise interactive) won't let me \
> adjust the volume.
I also get jumping volumes in the KMix dialog, when mousewheeling the sliders, so I \
guess this is a PulseAudio issue not Kmix' or Plasma's fault?
- Kai Uwe
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108223/#review27114
-----------------------------------------------------------
On Jan. 6, 2013, 11:52 p.m., Xuetian Weng wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/108223/
> -----------------------------------------------------------
>
> (Updated Jan. 6, 2013, 11:52 p.m.)
>
>
> Review request for Plasma, Solid, Aaron J. Seigo, Kai Uwe Broulik, and Christian \
> Esken.
>
> Description
> -------
>
> Similiar to https://git.reviewboard.kde.org/r/108222, this would fix the shadow \
> problem for kmix osd.
>
> Diffs
> -----
>
> gui/osdwidget.h 9ec0100
> gui/osdwidget.cpp 2dc202e
>
> Diff: http://git.reviewboard.kde.org/r/108223/diff/
>
>
> Testing
> -------
>
> localily tested, no problem
>
>
> Thanks,
>
> Xuetian Weng
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/108223/">http://git.reviewboard.kde.org/r/108223/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On February 10th, 2013, 10:04 a.m. UTC, \
<b>Christian Esken</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: \
2px solid #d0d0d0; padding-left: 10px;"> <pre style="white-space: pre-wrap; \
white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; \
word-wrap: break-word;">Just got a bug report that is likely realted to this change \
("started happening on kde 4.10"): Bug 314803 - OSD glitches out and \
freezes https://bugs.kde.org/show_bug.cgi?id=314803</pre>
</blockquote>
<p>On February 12th, 2013, 11:51 a.m. UTC, <b>Aaron J. Seigo</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">what leads you believe \
it is related to this change?
i've noticed that problem as well, though i believe it was well before this got \
merged in.
what i find happens is that if i press and hold the volume up/down button, the OSD \
will jump and then go back and jump again .. and sometimes eventually just freeze. so \
if it starts at 50% and i press and hold it will go 55, 60, 70, 55, 80, 60, 65, 70, \
75, 80, 85 ... i don't see how that has anything to do with this patch?
also, when it freezes, sometimes (perhaps always, but i can't say for sure) even \
the kmix icon in the systemtray (which remains otherwise interactive) won't let \
me adjust the volume.</pre> </blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I also get jumping \
volumes in the KMix dialog, when mousewheeling the sliders, so I guess this is a \
PulseAudio issue not Kmix' or Plasma's fault?</pre> <br />
<p>- Kai Uwe</p>
<br />
<p>On January 6th, 2013, 11:52 p.m. UTC, Xuetian Weng wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Plasma, Solid, Aaron J. Seigo, Kai Uwe Broulik, and Christian \
Esken.</div> <div>By Xuetian Weng.</div>
<p style="color: grey;"><i>Updated Jan. 6, 2013, 11:52 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Similiar to https://git.reviewboard.kde.org/r/108222, this would fix the \
shadow problem for kmix osd.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">localily tested, no problem</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>gui/osdwidget.h <span style="color: grey">(9ec0100)</span></li>
<li>gui/osdwidget.cpp <span style="color: grey">(2dc202e)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/108223/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic