'Re: Review Request 108425: Fixes for grace time in screenlocker'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request 108425: Fixes for grace time in screenlocker
From:       "Oliver Henshaw" <oliver.henshaw () gmail ! com>
Date:       2013-02-07 18:17:58
Message-ID: 20130207181758.13261.42970 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108425/
-----------------------------------------------------------

(Updated Feb. 7, 2013, 6:17 p.m.)

Review request for Plasma.

Description
-------

Series consists of 3 commits:

* Refactor grace time tracking

Set a boolean instead of checking whether timer is active. This is
required for the following commits.

* Stop grace period on unlock

It was safe to leak the grace timer when it was in the lock process,
since it was killed on unlock. Now it is not.

A password should always be required if the screenlocker is explicitly
triggered; but a screenlocker invoked while the grace timer from a
previous invocation is still active can be dismissed without a password,
at least for a short while. This also meant that the screenlocker
keyboard shortcut would not work until the grace timer expired.

* Respect Lock boolean in configuration

If not set to require password, don't start the grace period timer and
always consider in grace period.

This addresses bugs 310871 and 313997.
    http://bugs.kde.org/show_bug.cgi?id=310871
    http://bugs.kde.org/show_bug.cgi?id=313997

Diffs
-----

  ksmserver/screenlocker/ksldapp.h 51c0906fc6e54787af749872615770bd6005b4fb 
  ksmserver/screenlocker/ksldapp.cpp c07ac0ef1c6643415b8c13ba438628a1e118fb72 

Diff: http://git.reviewboard.kde.org/r/108425/diff/

Testing
-------

Tested with and without password required, tested with grace time set to zero in \
config file. Tested idle activation, user-requested activation and behaviour after \
return from idle activation.

Thanks,

Oliver Henshaw

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/108425/">http://git.reviewboard.kde.org/r/108425/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for Plasma.</div>
<div>By Oliver Henshaw.</div>

<p style="color: grey;"><i>Updated Feb. 7, 2013, 6:17 p.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Series consists of 3 commits:

* Refactor grace time tracking

Set a boolean instead of checking whether timer is active. This is
required for the following commits.

* Stop grace period on unlock

It was safe to leak the grace timer when it was in the lock process,
since it was killed on unlock. Now it is not.

A password should always be required if the screenlocker is explicitly
triggered; but a screenlocker invoked while the grace timer from a
previous invocation is still active can be dismissed without a password,
at least for a short while. This also meant that the screenlocker
keyboard shortcut would not work until the grace timer expired.

* Respect Lock boolean in configuration

If not set to require password, don&#39;t start the grace period timer and
always consider in grace period.</pre>
  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Tested with and without password required, tested with grace time set to \
zero in config file. Tested idle activation, user-requested activation and behaviour \
after return from idle activation.</pre>  </td>
 </tr>
</table>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>

 <a href="http://bugs.kde.org/show_bug.cgi?id=310871">310871</a>, 

 <a href="http://bugs.kde.org/show_bug.cgi?id=313997">313997</a>

</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>ksmserver/screenlocker/ksldapp.h <span style="color: \
grey">(51c0906fc6e54787af749872615770bd6005b4fb)</span></li>

 <li>ksmserver/screenlocker/ksldapp.cpp <span style="color: \
grey">(c07ac0ef1c6643415b8c13ba438628a1e118fb72)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/108425/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[prev in list] [next in list] [prev in thread] [next in thread] 