'Re: Review Request 108679: Plasmate: Make konsolepreview to work even if the plasmatepreviewerlog.tx'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request 108679: Plasmate: Make konsolepreview to work even if the plasmatepreviewerlog.tx
From:       "Commit Hook" <null () kde ! org>
Date:       2013-01-31 19:31:15
Message-ID: 20130131193115.924.20938 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108679/#review26464
-----------------------------------------------------------

This review has been submitted with commit f2cca0520428f941e0288f9cad3be155ad9e7cbf by Antonis \
Tsiapaliokas to branch master.

- Commit Hook

On Jan. 30, 2013, 9:29 p.m., Antonis Tsiapaliokas wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/108679/
> -----------------------------------------------------------
> 
> (Updated Jan. 30, 2013, 9:29 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Description
> -------
> 
> KStandarDirs::locate returns a path only if the file exists, the first time that we run \
> plasmate the plasmatepreviewerlog.txt doesn't exist so the konsolepreviewer doesn't work. In \
> order to fix this we are replacing the KStandarDirs:locate with KStandarDirs::locateLocal. \
> KStandarDirs::locateLocal always returns a path. Even if the file doesn't exist. 
> 
> Diffs
> -----
> 
> plasmate/konsole/konsolepreviewer.cpp 36dcc6b 
> plasmate/mainwindow.cpp 28f7a0e 
> 
> Diff: http://git.reviewboard.kde.org/r/108679/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Antonis Tsiapaliokas
> 
> 

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
    <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/108679/">http://git.reviewboard.kde.org/r/108679/</a>
  </td>
    </tr>
   </table>
   <br />

 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; \
white-space: -o-pre-wrap; word-wrap: break-word;">This review has been submitted with commit \
f2cca0520428f941e0288f9cad3be155ad9e7cbf by Antonis Tsiapaliokas to branch master.</pre>  <br \
/>

<p>- Commit</p>

<br />
<p>On January 30th, 2013, 9:29 p.m. UTC, Antonis Tsiapaliokas wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black solid;">  <tr>
  <td>

<div>Review request for Plasma.</div>
<div>By Antonis Tsiapaliokas.</div>

<p style="color: grey;"><i>Updated Jan. 30, 2013, 9:29 p.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px \
solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">KStandarDirs::locate \
returns a path only if the file exists, the first time that we run plasmate the \
plasmatepreviewerlog.txt doesn&#39;t exist so the konsolepreviewer doesn&#39;t work. In order \
to fix this we are replacing the KStandarDirs:locate with KStandarDirs::locateLocal. \
KStandarDirs::locateLocal always returns a path. Even if the file doesn&#39;t exist. </pre>
  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>plasmate/konsole/konsolepreviewer.cpp <span style="color: grey">(36dcc6b)</span></li>

 <li>plasmate/mainwindow.cpp <span style="color: grey">(28f7a0e)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/108679/diff/" style="margin-left: 3em;">View \
Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[prev in list] [next in list] [prev in thread] [next in thread] 