'Re: Review Request 108458: Fix webslice's handling of page resizes'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request 108458: Fix webslice's handling of page resizes
From:       Sebastian_Kügler <sebas () kde ! org>
Date:       2013-01-30 12:35:03
Message-ID: 20130130123503.5289.82886 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

> On Jan. 19, 2013, 10:22 p.m., Sebastian Kügler wrote:
> > Ship It!

Do you have commit access? If not, I can push this patch for you. Let me know...

- Sebastian

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108458/#review25812
-----------------------------------------------------------

On Jan. 17, 2013, 10:52 p.m., Mariusz Mazur wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/108458/
> -----------------------------------------------------------
> 
> (Updated Jan. 17, 2013, 10:52 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Description
> -------
> 
> Webslice applet doesn't handle refreshes/resizes correctly. This patch remedies the \
> situation, at least for my case. 
> 
> This addresses bug 310875.
> http://bugs.kde.org/show_bug.cgi?id=310875
> 
> 
> Diffs
> -----
> 
> applets/webslice/kgraphicswebslice.cpp 6c976a0 
> 
> Diff: http://git.reviewboard.kde.org/r/108458/diff/
> 
> 
> Testing
> -------
> 
> I've been using it on my desktop for a month now, no problems noticed.
> 
> 
> Thanks,
> 
> Mariusz Mazur
> 
> 

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/108458/">http://git.reviewboard.kde.org/r/108458/</a>
  </td>
    </tr>
   </table>
   <br />

<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;">  <p style="margin-top: 0;">On January 19th, 2013, 10:22 p.m. UTC, \
<b>Sebastian Kügler</b> wrote:</p>  <blockquote style="margin-left: 1em; \
border-left: 2px solid #d0d0d0; padding-left: 10px;">  <pre style="white-space: \
pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: \
-o-pre-wrap; word-wrap: break-word;">Ship It!</pre>  </blockquote>

</blockquote>

<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Do you have commit \
access? If not, I can push this patch for you. Let me know...</pre> <br />

<p>- Sebastian</p>

<br />
<p>On January 17th, 2013, 10:52 p.m. UTC, Mariusz Mazur wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for Plasma.</div>
<div>By Mariusz Mazur.</div>

<p style="color: grey;"><i>Updated Jan. 17, 2013, 10:52 p.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Webslice applet doesn&#39;t handle refreshes/resizes correctly. This \
patch remedies the situation, at least for my case.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">I&#39;ve been using it on my desktop for a month now, no problems \
noticed.</pre>  </td>
 </tr>
</table>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>

 <a href="http://bugs.kde.org/show_bug.cgi?id=310875">310875</a>

</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>applets/webslice/kgraphicswebslice.cpp <span style="color: \
grey">(6c976a0)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/108458/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[prev in list] [next in list] [prev in thread] [next in thread] 