[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request 108664: Remove absolute paths from Plasma/Generic packages
From: Sebastian_Kügler <sebas () kde ! org>
Date: 2013-01-29 23:00:21
Message-ID: 20130129230021.16849.37682 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
> On Jan. 29, 2013, 10:51 p.m., Sebastian Kügler wrote:
> > Patch looks good, code *now* does what I'd expect it to.
> >
> > I've tested it, and it fixes the issue.
> >
> > A grep through my src checkouts reveals 29 uses of PackageStructure with \
> > Plasma/Generic, so the work to check it all seems possible (we'll have to do that \
> > anyway, at some point, moving to F5).
BUG:314071
btw :)
- Sebastian
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108664/#review26386
-----------------------------------------------------------
On Jan. 29, 2013, 8:07 p.m., Aaron J. Seigo wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/108664/
> -----------------------------------------------------------
>
> (Updated Jan. 29, 2013, 8:07 p.m.)
>
>
> Review request for Plasma, Marco Martin and Sebastian Kügler.
>
>
> Description
> -------
>
> This path gets rid of the absolute defaultRootPath for Plasma/Generic packages. to \
> compensate for this change, it also introduces the ability for Package to handle \
> relative paths properly, a bit more like what libplasma2 already does.
> Without this, any Plasma/Generic packages installed in $HOME will render any system \
> installed packages unreachable.
>
> Diffs
> -----
>
> plasma/applet.cpp 2f7fbdb
> plasma/package.cpp 1a49531
> plasma/packagestructure.cpp b66069c
> plasma/private/package_p.h a572c12
>
> Diff: http://git.reviewboard.kde.org/r/108664/diff/
>
>
> Testing
> -------
>
> packagestructuretest passes; plasmoidviewer still works (installed packages; \
> relative paths; absolute paths); plasma-desktop functions correctly (activity \
> manager and widgets explorer inc); more testing needed.
> may require a full scan of all uses of Plasma/Generic packages :/
>
>
> Thanks,
>
> Aaron J. Seigo
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/108664/">http://git.reviewboard.kde.org/r/108664/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On January 29th, 2013, 10:51 p.m. UTC, \
<b>Sebastian Kügler</b> wrote:</p> <blockquote style="margin-left: 1em; \
border-left: 2px solid #d0d0d0; padding-left: 10px;"> <pre style="white-space: \
pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: \
-o-pre-wrap; word-wrap: break-word;">Patch looks good, code *now* does what I'd \
expect it to.
I've tested it, and it fixes the issue.
A grep through my src checkouts reveals 29 uses of PackageStructure with \
Plasma/Generic, so the work to check it all seems possible (we'll have to do that \
anyway, at some point, moving to F5).</pre> </blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">BUG:314071
btw :)</pre>
<br />
<p>- Sebastian</p>
<br />
<p>On January 29th, 2013, 8:07 p.m. UTC, Aaron J. Seigo wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Plasma, Marco Martin and Sebastian Kügler.</div>
<div>By Aaron J. Seigo.</div>
<p style="color: grey;"><i>Updated Jan. 29, 2013, 8:07 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">This path gets rid of the absolute defaultRootPath for Plasma/Generic \
packages. to compensate for this change, it also introduces the ability for Package \
to handle relative paths properly, a bit more like what libplasma2 already does.
Without this, any Plasma/Generic packages installed in $HOME will render any system \
installed packages unreachable.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">packagestructuretest passes; plasmoidviewer still works (installed \
packages; relative paths; absolute paths); plasma-desktop functions correctly \
(activity manager and widgets explorer inc); more testing needed.
may require a full scan of all uses of Plasma/Generic packages :/</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>plasma/applet.cpp <span style="color: grey">(2f7fbdb)</span></li>
<li>plasma/package.cpp <span style="color: grey">(1a49531)</span></li>
<li>plasma/packagestructure.cpp <span style="color: grey">(b66069c)</span></li>
<li>plasma/private/package_p.h <span style="color: grey">(a572c12)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/108664/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic