--===============0837001111331661597== Content-Type: multipart/alternative; boundary="===============0625958172660927200==" --===============0625958172660927200== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108425/#review26384 ----------------------------------------------------------- The "Stop grace period on unlock" part might be serious enough to need to go into 4.10.0. The patch series is available at clones/kde-workspace/oliverhenshaw/kde-workspace in the review/screenlocker-gracetime branch. - Oliver Henshaw On Jan. 15, 2013, 3:30 p.m., Oliver Henshaw wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/108425/ > ----------------------------------------------------------- > > (Updated Jan. 15, 2013, 3:30 p.m.) > > > Review request for Plasma. > > > Description > ------- > > Series consists of 3 commits: > > * Refactor grace time tracking > > Set a boolean instead of checking whether timer is active. This is > required for the following commits. > > * Stop grace period on unlock > > It was safe to leak the grace timer when it was in the lock process, > since it was killed on unlock. Now it is not. > > A password should always be required if the screenlocker is explicitly > triggered; but a screenlocker invoked while the grace timer from a > previous invocation is still active can be dismissed without a password, > at least for a short while. This also meant that the screenlocker > keyboard shortcut would not work until the grace timer expired. > > * Respect Lock boolean in configuration > > If not set to require password, don't start the grace period timer and > always consider in grace period. > > > This addresses bug 310871. > http://bugs.kde.org/show_bug.cgi?id=310871 > > > Diffs > ----- > > ksmserver/screenlocker/ksldapp.h 51c0906fc6e54787af749872615770bd6005b4fb > ksmserver/screenlocker/ksldapp.cpp c07ac0ef1c6643415b8c13ba438628a1e118fb72 > > Diff: http://git.reviewboard.kde.org/r/108425/diff/ > > > Testing > ------- > > Tested with and without password required, tested with grace time set to zero in config file. Tested idle activation, user-requested activation and behaviour after return from idle activation. > > > Thanks, > > Oliver Henshaw > > --===============0625958172660927200== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit

This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108425/

The "Stop grace period on unlock" part might be serious enough to need to go into 4.10.0. The patch series is available at clones/kde-workspace/oliverhenshaw/kde-workspace in the review/screenlocker-gracetime branch.

- Oliver

On January 15th, 2013, 3:30 p.m. UTC, Oliver Henshaw wrote:

Review request for Plasma.

By Oliver Henshaw.

Updated Jan. 15, 2013, 3:30 p.m.

Description

Series consists of 3 commits:

* Refactor grace time tracking

Set a boolean instead of checking whether timer is active. This is
required for the following commits.

* Stop grace period on unlock

It was safe to leak the grace timer when it was in the lock process,
since it was killed on unlock. Now it is not.

A password should always be required if the screenlocker is explicitly
triggered; but a screenlocker invoked while the grace timer from a
previous invocation is still active can be dismissed without a password,
at least for a short while. This also meant that the screenlocker
keyboard shortcut would not work until the grace timer expired.

* Respect Lock boolean in configuration

If not set to require password, don't start the grace period timer and
always consider in grace period.

Testing

Tested with and without password required, tested with grace time set to zero in config file. Tested idle activation, user-requested activation and behaviour after return from idle activation.

Bugs: 310871

Diffs

ksmserver/screenlocker/ksldapp.h (51c0906fc6e54787af749872615770bd6005b4fb)
ksmserver/screenlocker/ksldapp.cpp (c07ac0ef1c6643415b8c13ba438628a1e118fb72)

--===============0625958172660927200==-- --===============0837001111331661597== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel --===============0837001111331661597==--