[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request 108643: Fix screenlocker lockwindow geometry on screen resizes (take 2)
From: Thomas_Lübking <thomas.luebking () gmail ! com>
Date: 2013-01-28 20:51:34
Message-ID: 20130128205134.9626.96341 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
> On Jan. 28, 2013, 3:30 p.m., Thomas Lübking wrote:
> > What kinda strucks me is that the window is translucent for the Qt::transparent.
> > This also requires it to be 32bit, ie. ARGB - is that lockerwindow constructed \
> > out of sth. else here (eg. plasma-desktop) or do you eventually run into this \
> > with the oxygen-transparent style or the resp. settings of QtCurve or Bespin?
>
> Aaron J. Seigo wrote:
> yes, that's also true: it probably doesn't need to be translucent. or rather, \
> shouldn't be because we actively do *not* want content visible through it. this \
> could be a hold-over from prior incarnations of the system.
> feel free to take the changes in this patch and make more changes :)
>
> Aaron J. Seigo wrote:
> aaah .. this was probably indeed related to screensavers and widgets-on-screensaver \
> which requires the ability to see through various windows and thus argb.
The locker window is not 32bit here.
(print yourself the winId() and from VT1 or ssh do "xwininfo -id <WID>"
The "Depth" says "24" here.
If it does for you as well, this could be a driver issue (eg. the MSAA problem - \
would not happen with XRender compositing then)
- Thomas
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108643/#review26314
-----------------------------------------------------------
On Jan. 28, 2013, 2:38 p.m., Aaron J. Seigo wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/108643/
> -----------------------------------------------------------
>
> (Updated Jan. 28, 2013, 2:38 p.m.)
>
>
> Review request for kwin, Plasma, Martin Gräßlin, and Thomas Lübking.
>
>
> Description
> -------
>
> Updated version of Thomas' patch from https://git.reviewboard.kde.org/r/108585/
>
> Tested and works in the use case originally noted as broken, and as a bonus \
> includes getting rid of usage of libkephal.
>
> This addresses bug 313835.
> http://bugs.kde.org/show_bug.cgi?id=313835
>
>
> Diffs
> -----
>
> ksmserver/screenlocker/CMakeLists.txt bab32eda33526bbe5149bc903fbb6a28fb9d28d7
> ksmserver/screenlocker/greeter/CMakeLists.txt \
> f89a98d66b774d00bbe8b881c66298ed7e339dac \
> ksmserver/screenlocker/greeter/greeterapp.cpp \
> b41cc74ce4f072610772366be3abdf1f4f25f24e ksmserver/screenlocker/lockwindow.h \
> 5cbc76956a4b83d46da96a7ef768116ffdd505c3 ksmserver/screenlocker/lockwindow.cpp \
> 147853b5625277a35bf01247366c6597636c638c
> Diff: http://git.reviewboard.kde.org/r/108643/diff/
>
>
> Testing
> -------
>
> start locker when internal laptop screen is on
> plug in external screen
> kscreen automagically switches it on and the laptop screen off
> locker displays properly
>
>
> Thanks,
>
> Aaron J. Seigo
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/108643/">http://git.reviewboard.kde.org/r/108643/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On January 28th, 2013, 3:30 p.m. UTC, <b>Thomas \
Lübking</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;"> <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">What kinda strucks me is that the window is translucent for the \
Qt::transparent. This also requires it to be 32bit, ie. ARGB - is that lockerwindow \
constructed out of sth. else here (eg. plasma-desktop) or do you eventually run into \
this with the oxygen-transparent style or the resp. settings of QtCurve or \
Bespin?</pre> </blockquote>
<p>On January 28th, 2013, 4:05 p.m. UTC, <b>Aaron J. Seigo</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">yes, that's also \
true: it probably doesn't need to be translucent. or rather, shouldn't be \
because we actively do *not* want content visible through it. this could be a \
hold-over from prior incarnations of the system.
feel free to take the changes in this patch and make more changes :)</pre>
</blockquote>
<p>On January 28th, 2013, 4:08 p.m. UTC, <b>Aaron J. Seigo</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">aaah .. this was \
probably indeed related to screensavers and widgets-on-screensaver which requires the \
ability to see through various windows and thus argb.</pre> </blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">The locker window is not \
32bit here. (print yourself the winId() and from VT1 or ssh do "xwininfo -id \
<WID>" The "Depth" says "24" here.
If it does for you as well, this could be a driver issue (eg. the MSAA problem - \
would not happen with XRender compositing then)</pre> <br />
<p>- Thomas</p>
<br />
<p>On January 28th, 2013, 2:38 p.m. UTC, Aaron J. Seigo wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for kwin, Plasma, Martin Gräßlin, and Thomas Lübking.</div>
<div>By Aaron J. Seigo.</div>
<p style="color: grey;"><i>Updated Jan. 28, 2013, 2:38 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Updated version of Thomas' patch from \
https://git.reviewboard.kde.org/r/108585/
Tested and works in the use case originally noted as broken, and as a bonus includes \
getting rid of usage of libkephal.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">start locker when internal laptop screen is on plug in external screen
kscreen automagically switches it on and the laptop screen off
locker displays properly</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=313835">313835</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>ksmserver/screenlocker/CMakeLists.txt <span style="color: \
grey">(bab32eda33526bbe5149bc903fbb6a28fb9d28d7)</span></li>
<li>ksmserver/screenlocker/greeter/CMakeLists.txt <span style="color: \
grey">(f89a98d66b774d00bbe8b881c66298ed7e339dac)</span></li>
<li>ksmserver/screenlocker/greeter/greeterapp.cpp <span style="color: \
grey">(b41cc74ce4f072610772366be3abdf1f4f25f24e)</span></li>
<li>ksmserver/screenlocker/lockwindow.h <span style="color: \
grey">(5cbc76956a4b83d46da96a7ef768116ffdd505c3)</span></li>
<li>ksmserver/screenlocker/lockwindow.cpp <span style="color: \
grey">(147853b5625277a35bf01247366c6597636c638c)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/108643/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic