'Review Request 108559: some screen locker visual fix'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Review Request 108559: some screen locker visual fix
From:       "Xuetian Weng" <wengxt () gmail ! com>
Date:       2013-01-22 20:20:35
Message-ID: 20130122202035.22004.50660 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108559/
-----------------------------------------------------------

Review request for Plasma and Marco Martin.

Description
-------

1. string in qml doesn't have "empty" property, use length to check it's empty or \
not. 2. AccelButton's string doesn't have &, which will result in unpressable accel \
key when process i18n string (for example Chinese). (since we are already string \
freeze.. this part might not go into KDE/4.10) 3. AccelButton will display & if \
showAccel is false, here we introduce a new property for normal string 4. fallback to \
loginName if fullName is empty. 5. console.log in AccelButton is removed.

Diffs
-----

  ksmserver/screenlocker/greeter/greeterapp.cpp 32a4d16 
  ksmserver/screenlocker/greeter/themes/org.kde.passworddialog/contents/ui/AccelButton.qml \
108a39d   ksmserver/screenlocker/greeter/themes/org.kde.passworddialog/contents/ui/Greeter.qml \
65e348d 

Diff: http://git.reviewboard.kde.org/r/108559/diff/

Testing
-------

user name is shown as expected. accel key will work for i18n case.

Thanks,

Xuetian Weng

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/108559/">http://git.reviewboard.kde.org/r/108559/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for Plasma and Marco Martin.</div>
<div>By Xuetian Weng.</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">1. string in qml doesn&#39;t have &quot;empty&quot; property, use length \
to check it&#39;s empty or not. 2. AccelButton&#39;s string doesn&#39;t have &amp;, \
which will result in unpressable accel key when process i18n string (for example \
Chinese). (since we are already string freeze.. this part might not go into KDE/4.10) \
3. AccelButton will display &amp; if showAccel is false, here we introduce a new \
property for normal string 4. fallback to loginName if fullName is empty.
5. console.log in AccelButton is removed.</pre>
  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">user name is shown as expected. accel key will work for i18n case.</pre> \
</td>  </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>ksmserver/screenlocker/greeter/greeterapp.cpp <span style="color: \
grey">(32a4d16)</span></li>

 <li>ksmserver/screenlocker/greeter/themes/org.kde.passworddialog/contents/ui/AccelButton.qml \
<span style="color: grey">(108a39d)</span></li>

 <li>ksmserver/screenlocker/greeter/themes/org.kde.passworddialog/contents/ui/Greeter.qml \
<span style="color: grey">(65e348d)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/108559/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[prev in list] [next in list] [prev in thread] [next in thread] 