[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request 108453: add an orientation engine and applet to plasma-mobile for screen and touc
From: "Jeremy Paul Whiting" <jpwhiting () kde ! org>
Date: 2013-01-21 16:21:57
Message-ID: 20130121162157.32611.24905 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
> On Jan. 21, 2013, 2:54 a.m., Marco Martin wrote:
> > looks nice (just some small nitpicks in the ui)
> > as procedure, now it should be in integration for a while(Aaron, can you do it?)
> > , tested, and hopefully merged in few days
> >
> > also, the applet should be in the default setup by changing the default \
> > plasma-device-appetsrc in the plasma-mobile-config repo
Ok, I fixed those three issues with a commit on the orientation branch.
- Jeremy Paul
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108453/#review25884
-----------------------------------------------------------
On Jan. 17, 2013, 1:31 p.m., Jeremy Paul Whiting wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/108453/
> -----------------------------------------------------------
>
> (Updated Jan. 17, 2013, 1:31 p.m.)
>
>
> Review request for Plasma, Aaron J. Seigo and Marco Martin.
>
>
> Description
> -------
>
> This adds an orientation dataengine to plasma which reacts to qt sensors and also \
> takes commands via the orientation applet to rotate left or right. Rotation \
> rotates both the touch screen device via xinput calls and the x screen via \
> libkscreen.
> TODO: Add a lock/unlock to the applet once qt sensors are providing input.
>
> also, I'm not sure why the orientation applet expansion is so wide, it really only \
> needs to accomodate those two icons.
>
> Diffs
> -----
>
> CMakeLists.txt 7d030f0bd962225b9787bb8a1ff8037dd21a0b3c
> applets/CMakeLists.txt f33ba4066b32df625ac143698d5e546ca302e523
> applets/orientation/Messages.sh PRE-CREATION
> applets/orientation/contents/code/Orientation.qml PRE-CREATION
> applets/orientation/metadata.desktop PRE-CREATION
> cmake/modules/FindQtMobility.cmake PRE-CREATION
> dataengines/CMakeLists.txt c9bfa9358bd6eeb3773b811c46a043305abd60f7
> dataengines/orientation/CMakeLists.txt PRE-CREATION
> dataengines/orientation/orientation.operations PRE-CREATION
> dataengines/orientation/orientationengine.h PRE-CREATION
> dataengines/orientation/orientationengine.cpp PRE-CREATION
> dataengines/orientation/orientationjob.h PRE-CREATION
> dataengines/orientation/orientationjob.cpp PRE-CREATION
> dataengines/orientation/orientationservice.h PRE-CREATION
> dataengines/orientation/orientationservice.cpp PRE-CREATION
> dataengines/orientation/plasma-engine-orientation.desktop PRE-CREATION
> qmlpackages/contour-tablet-homescreen/contents/config/plasma-default-layoutrc \
> 98d9b7316eb543a172b49ae4cb8110c87d189a56
> Diff: http://git.reviewboard.kde.org/r/108453/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Jeremy Paul Whiting
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/108453/">http://git.reviewboard.kde.org/r/108453/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On January 21st, 2013, 2:54 a.m. MST, <b>Marco \
Martin</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;"> <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">looks nice (just some small nitpicks in the ui) as procedure, now it \
should be in integration for a while(Aaron, can you do it?) , tested, and hopefully \
merged in few days
also, the applet should be in the default setup by changing the default \
plasma-device-appetsrc in the plasma-mobile-config repo </pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Ok, I fixed those three \
issues with a commit on the orientation branch.</pre> <br />
<p>- Jeremy Paul</p>
<br />
<p>On January 17th, 2013, 1:31 p.m. MST, Jeremy Paul Whiting wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Plasma, Aaron J. Seigo and Marco Martin.</div>
<div>By Jeremy Paul Whiting.</div>
<p style="color: grey;"><i>Updated Jan. 17, 2013, 1:31 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">This adds an orientation dataengine to plasma which reacts to qt sensors \
and also takes commands via the orientation applet to rotate left or right. Rotation \
rotates both the touch screen device via xinput calls and the x screen via \
libkscreen.
TODO: Add a lock/unlock to the applet once qt sensors are providing input.
also, I'm not sure why the orientation applet expansion is so wide, it really \
only needs to accomodate those two icons.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>CMakeLists.txt <span style="color: \
grey">(7d030f0bd962225b9787bb8a1ff8037dd21a0b3c)</span></li>
<li>applets/CMakeLists.txt <span style="color: \
grey">(f33ba4066b32df625ac143698d5e546ca302e523)</span></li>
<li>applets/orientation/Messages.sh <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>applets/orientation/contents/code/Orientation.qml <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>applets/orientation/metadata.desktop <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>cmake/modules/FindQtMobility.cmake <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>dataengines/CMakeLists.txt <span style="color: \
grey">(c9bfa9358bd6eeb3773b811c46a043305abd60f7)</span></li>
<li>dataengines/orientation/CMakeLists.txt <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>dataengines/orientation/orientation.operations <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>dataengines/orientation/orientationengine.h <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>dataengines/orientation/orientationengine.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>dataengines/orientation/orientationjob.h <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>dataengines/orientation/orientationjob.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>dataengines/orientation/orientationservice.h <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>dataengines/orientation/orientationservice.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>dataengines/orientation/plasma-engine-orientation.desktop <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>qmlpackages/contour-tablet-homescreen/contents/config/plasma-default-layoutrc \
<span style="color: grey">(98d9b7316eb543a172b49ae4cb8110c87d189a56)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/108453/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic