'Re: Review Request 108474: use 'send email to' for in krunner result for email address query'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request 108474: use 'send email to' for in krunner result for email address query
From:       "Commit Hook" <null () kde ! org>
Date:       2013-01-21 11:19:47
Message-ID: 20130121111947.24229.66488 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108474/#review25886
-----------------------------------------------------------

This review has been submitted with commit 4a341f115eca937bca43f37076500ce9312f8aee \
by Reza Shah to branch master.

- Commit Hook

On Jan. 18, 2013, 2:21 p.m., Reza Shah wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/108474/
> -----------------------------------------------------------
> 
> (Updated Jan. 18, 2013, 2:21 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Description
> -------
> 
> I'm trying to improve krunner as mentioned in this bug: \
> https://bugs.kde.org/show_bug.cgi?id=202336. By using 'Send email to' instead of \
> 'Launch with' in query result. 
> And together with this https://git.reviewboard.kde.org/r/108471/
> 
> We can have something like in screenshot.
> 
> 
> This addresses bug 202336.
> http://bugs.kde.org/show_bug.cgi?id=202336
> 
> 
> Diffs
> -----
> 
> plasma/generic/runners/locations/locationrunner.cpp 67c3be4 
> 
> Diff: http://git.reviewboard.kde.org/r/108474/diff/
> 
> 
> Testing
> -------
> 
> Tested against master, worked fine.
> 
> 
> File Attachments
> ----------------
> 
> email
> http://git.reviewboard.kde.org/media/uploaded/files/2013/01/18/krunneremail.png
> 
> 
> Thanks,
> 
> Reza Shah
> 
> 

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/108474/">http://git.reviewboard.kde.org/r/108474/</a>
  </td>
    </tr>
   </table>
   <br />

 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been \
submitted with commit 4a341f115eca937bca43f37076500ce9312f8aee by Reza Shah to branch \
master.</pre>  <br />

<p>- Commit</p>

<br />
<p>On January 18th, 2013, 2:21 p.m. UTC, Reza Shah wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for Plasma.</div>
<div>By Reza Shah.</div>

<p style="color: grey;"><i>Updated Jan. 18, 2013, 2:21 p.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">I&#39;m trying to improve krunner as mentioned in this bug: \
https://bugs.kde.org/show_bug.cgi?id=202336. By using &#39;Send email to&#39; instead \
of &#39;Launch with&#39; in query result.

And together with this https://git.reviewboard.kde.org/r/108471/

We can have something like in screenshot.
</pre>
  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Tested against master, worked fine.</pre>  </td>
 </tr>
</table>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>

 <a href="http://bugs.kde.org/show_bug.cgi?id=202336">202336</a>

</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>plasma/generic/runners/locations/locationrunner.cpp <span style="color: \
grey">(67c3be4)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/108474/diff/" style="margin-left: \
3em;">View Diff</a></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments \
</h1>

<ul>

 <li><a href="http://git.reviewboard.kde.org/media/uploaded/files/2013/01/18/krunneremail.png">email</a></li>

</ul>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[prev in list] [next in list] [prev in thread] [next in thread] 