[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request 108375: fix bug 311116 / screenlocker hiding
From: Thomas_Lübking <thomas.luebking () gmail ! com>
Date: 2013-01-16 22:14:18
Message-ID: 20130116221418.27471.7767 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
> On Jan. 16, 2013, 9:10 p.m., Oliver Henshaw wrote:
> > ksmserver/screenlocker/greeter/greeterapp.cpp, line 131
> > <http://git.reviewboard.kde.org/r/108375/diff/2/?file=107023#file107023line131>
> >
> > It seems the DESIGN document is still correct and lockwindow.cpp should be hiding \
> > the desktop from prying eyes. So something like this may need to be done there, \
> > too. After all, what happens if the legacy screensaver crashes?
There's indeed a lockwindow - you'll get it either after the greeter crashed (kill \
-11; it will be restarted) or when you hide the greeter.
The LockWindow does NOT adjust to screen resizes.
Reg. the other patch, the greeter performs all relevant input processing and if \
that's not possible because the greeter is hidden, there's not way to show it back. \
The greeter cannot be hidden (and it makes little sense anyway - either there's a \
fancy show or the screen is off or nobody is looking anyway)
I'm dropping the issue since it's not an issue with this patch.
- Thomas
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108375/#review25695
-----------------------------------------------------------
On Jan. 13, 2013, 9:32 p.m., Thomas Lübking wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/108375/
> -----------------------------------------------------------
>
> (Updated Jan. 13, 2013, 9:32 p.m.)
>
>
> Review request for Plasma and Martin Gräßlin.
>
>
> Description
> -------
>
> Ok. Redirecting to plasma.
>
> The patch fixes:
>
> a) setting the properties
> ... to happen on show, this is required because the "hide()" will (usually and in \
> this case) destroy the drawable ("window") and with it all properties on the \
> server; so they need to be re/set "when required".
> b) input processing
> Relevant events are sucked so that we don't receive them more than once (usually \
> i'd discourage from installing an eventfilter on the application but the \
> screenlocker is ideally of low event occurrance anyway)
> c) triggering events
> Not really a fix but the "saver" is now hidden on any keyPress and only reshown on \
> escape keyRelease (iirc this was the behavior of most screenSavers when i used them \
> because there was no dpms ...)
> d) screen geometry adaptation
> if the user attaches a screen and that auto-extends the desktop, the screenlocker \
> currently yells a warning and happily exposes the desktop (there's still a problem \
> in case KWin fades in the locker but that's not matter to this patch)
>
> This addresses bug 311116.
> http://bugs.kde.org/show_bug.cgi?id=311116
>
>
> Diffs
> -----
>
> ksmserver/screenlocker/greeter/greeter.cpp f5918f9
> ksmserver/screenlocker/greeter/greeterapp.h 6b2c263
> ksmserver/screenlocker/greeter/greeterapp.cpp a35c8ae
> ksmserver/screenlocker/greeter/screensaverwindow.cpp adb2587
>
> Diff: http://git.reviewboard.kde.org/r/108375/diff/
>
>
> Testing
> -------
>
> "Screensaver" - Emulation ;-)
>
> m_showScreenSaver = true;
> // screensaverWindow->setBackground(backgroundPix);
> screensaverWindow->setAutoFillBackground(true);
>
>
> Thanks,
>
> Thomas Lübking
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/108375/">http://git.reviewboard.kde.org/r/108375/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On January 16th, 2013, 9:10 p.m. UTC, <b>Oliver \
Henshaw</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="http://git.reviewboard.kde.org/r/108375/diff/2/?file=107023#file107023line131" \
style="color: black; font-weight: bold; text-decoration: \
underline;">ksmserver/screenlocker/greeter/greeterapp.cpp</a> <span \
style="font-weight: normal;">
(Diff revision 2)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">128</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span \
class="kt">void</span> <span class="n">UnlockApp</span><span class="o">::</span><span \
class="n">desktopResized</span><span class="p">()</span></pre></td> </tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">It seems the DESIGN \
document is still correct and lockwindow.cpp should be hiding the desktop from prying \
eyes. So something like this may need to be done there, too. After all, what happens \
if the legacy screensaver crashes?</pre> </blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">There's \
indeed a lockwindow - you'll get it either after the greeter crashed (kill -11; \
it will be restarted) or when you hide the greeter.
The LockWindow does NOT adjust to screen resizes.
Reg. the other patch, the greeter performs all relevant input processing and if \
that's not possible because the greeter is hidden, there's not way to show it \
back. The greeter cannot be hidden (and it makes little sense anyway - either \
there's a fancy show or the screen is off or nobody is looking anyway)
I'm dropping the issue since it's not an issue with this patch.</pre>
<br />
<p>- Thomas</p>
<br />
<p>On January 13th, 2013, 9:32 p.m. UTC, Thomas Lübking wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Plasma and Martin Gräßlin.</div>
<div>By Thomas Lübking.</div>
<p style="color: grey;"><i>Updated Jan. 13, 2013, 9:32 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Ok. Redirecting to plasma.
The patch fixes:
a) setting the properties
... to happen on show, this is required because the "hide()" will (usually \
and in this case) destroy the drawable ("window") and with it all \
properties on the server; so they need to be re/set "when required".
b) input processing
Relevant events are sucked so that we don't receive them more than once (usually \
i'd discourage from installing an eventfilter on the application but the \
screenlocker is ideally of low event occurrance anyway)
c) triggering events
Not really a fix but the "saver" is now hidden on any keyPress and only \
reshown on escape keyRelease (iirc this was the behavior of most screenSavers when i \
used them because there was no dpms ...)
d) screen geometry adaptation
if the user attaches a screen and that auto-extends the desktop, the screenlocker \
currently yells a warning and happily exposes the desktop (there's still a \
problem in case KWin fades in the locker but that's not matter to this \
patch)</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">"Screensaver" - Emulation ;-)
m_showScreenSaver = true;
// screensaverWindow->setBackground(backgroundPix);
screensaverWindow->setAutoFillBackground(true);</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=311116">311116</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>ksmserver/screenlocker/greeter/greeter.cpp <span style="color: \
grey">(f5918f9)</span></li>
<li>ksmserver/screenlocker/greeter/greeterapp.h <span style="color: \
grey">(6b2c263)</span></li>
<li>ksmserver/screenlocker/greeter/greeterapp.cpp <span style="color: \
grey">(a35c8ae)</span></li>
<li>ksmserver/screenlocker/greeter/screensaverwindow.cpp <span style="color: \
grey">(adb2587)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/108375/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic