[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: XDpms in screenlocker
From: Dario Freddi <drf54321 () gmail ! com>
Date: 2013-01-14 11:32:13
Message-ID: CAFFVnfNYVdW=gyoW_N4HCO-bFFz88oCH1vyUbVFF0XqZsaggAA () mail ! gmail ! com
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
Hi everyone,
2013/1/14 Oliver Henshaw <oliver.henshaw@gmail.com>
> On 13 January 2013 22:57, Thomas L=FCbking <thomas.luebking@gmail.com>
> wrote:
> > ** please keep me in cc as well as likely dario **
> >
> > I looked into the powerdevil sources, reactivated the turnOffScreen dbu=
s
> > method, implemented it and that works - more or less (screeen turns bla=
ck
> > for a moment and then comes back up)
> >
> > // Let's pretend we're resuming
> > core()->onResumeFromSuspend();
> >
> > Commenting that away works just as expected.
>
> The same fix is in https://git.reviewboard.kde.org/r/106795/ which I
> forgot about, sorry. Note that I think this is really due to an X bug,
> if you 'sleep 10; xset -q' before asking powerdevil to turn off the
> screen you can see that X11 thinks that the screen is still off when
> it has come back on.
>
Indeed. The reason why that call was put into place was to set the idle
timer to zero whenever a trigger came up. I clearly remember it used to
solve also another problem, which I don't recall now (blame on me for not
commenting on that part), but it's apparently safe to get that out of the
way.
I also agree with Oliver's analysis.
Needless to say that if we all agree that commenting out that method should
fix this issue, that RR is good to merge.
> [1] There's actually an explanation for that behavior which might be
> > relevant in this case:
> > * The calls to usleep below are necessary to
> > * delay the actual DPMS mode setting briefly.
> > * Without them, it's likely that the mode will be
> > * set between the Down and Up key transitions, in
> > * which case the Up transition may immediately
> > * turn the display back on.
>
> I think it's more than that, as mentioned above. Or maybe xset is
> papering over the same bug?
>
[Attachment #5 (text/html)]
<div dir="ltr">Hi everyone,<div class="gmail_extra"><br><div \
class="gmail_quote">2013/1/14 Oliver Henshaw <span dir="ltr"><<a \
href="mailto:oliver.henshaw@gmail.com" \
target="_blank">oliver.henshaw@gmail.com</a>></span><br> <blockquote \
class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc \
solid;padding-left:1ex"><div class="im">On 13 January 2013 22:57, Thomas Lübking \
<<a href="mailto:thomas.luebking@gmail.com">thomas.luebking@gmail.com</a>> \
wrote:<br>
> ** please keep me in cc as well as likely dario **<br>
><br>
</div><div class="im">> I looked into the powerdevil sources, reactivated the \
turnOffScreen dbus<br> > method, implemented it and that works - more or less \
(screeen turns black<br> > for a moment and then comes back up)<br>
><br>
</div><div class="im">> // Let's pretend we're resuming<br>
> core()->onResumeFromSuspend();<br>
><br>
> Commenting that away works just as expected.<br>
<br>
</div>The same fix is in <a href="https://git.reviewboard.kde.org/r/106795/" \
target="_blank">https://git.reviewboard.kde.org/r/106795/</a> which I<br> forgot \
about, sorry. Note that I think this is really due to an X bug,<br> if you 'sleep \
10; xset -q' before asking powerdevil to turn off the<br> screen you can see that \
X11 thinks that the screen is still off when<br> it has come back \
on.<br></blockquote><div><br></div><div style>Indeed. The reason why that call was \
put into place was to set the idle timer to zero whenever a trigger came up. I \
clearly remember it used to solve also another problem, which I don't recall now \
(blame on me for not commenting on that part), but it's apparently safe to get \
that out of the way.</div> <div style><br></div><div style>I also agree with \
Oliver's analysis.</div><div style><br></div><div style>Needless to say that if \
we all agree that commenting out that method should fix this issue, that RR is good \
to merge.</div> <div><br></div><blockquote class="gmail_quote" style="margin:0 0 0 \
.8ex;border-left:1px #ccc solid;padding-left:1ex"><div class="im"> > [1] \
There's actually an explanation for that behavior which might be<br> > \
relevant in this case:<br> > * The calls to usleep below are necessary to<br>
> * delay the actual DPMS mode setting briefly.<br>
> * Without them, it's likely that the mode will be<br>
> * set between the Down and Up key transitions, in<br>
> * which case the Up transition may immediately<br>
> * turn the display back on.<br>
<br>
</div>I think it's more than that, as mentioned above. Or maybe xset is<br>
papering over the same bug?<br>
</blockquote></div><br></div></div>
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic