'Re: Review Request 108400: Improve highlighted contrast in thumbnail tabbox'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request 108400: Improve highlighted contrast in thumbnail tabbox
From:       Martin_Gräßlin <mgraesslin () kde ! org>
Date:       2013-01-14 8:09:00
Message-ID: 20130114080900.16418.32339 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108400/
-----------------------------------------------------------

(Updated Jan. 14, 2013, 9:08 a.m.)

Review request for kwin and Plasma.

Changes
-------

adding plasma as I would like to get some feedback on whether highlight is the right \
element to use in general or whether we should migrate away from it as it seems to be \
unusable with the default theme for our uses.

Description
-------

Improve highlighted contrast in thumbnail tabbox

Air's hovered svg provides only a thin frame around the borders, too
little to quickly spot the highlighted item when the whole widget is
only around for a few milliseconds (as is usual with the tabbox).

This patch paints a rectangle with rounded corners behind the
highlighted item instead, making it much easier to spot the currently
highlighted item.

Aimed for master and KDE/4.10.

Diffs
-----

  kwin/tabbox/qml/clients/thumbnails/contents/ui/main.qml \
4c33703d54c84fd54da94f821234e4cbd9c1c001 

Diff: http://git.reviewboard.kde.org/r/108400/diff/

Testing
-------

Tested with Air, Oxygen and Slim Glow, all work as expected, all show contrast \
improvements, while still looking beautiful. :)

File Attachments
----------------

before, try spotting the highlighted item
  http://git.reviewboard.kde.org/media/uploaded/files/2013/01/14/kwin-tabbox-contrast-before.png
  after, much easier to find
  http://git.reviewboard.kde.org/media/uploaded/files/2013/01/14/kwin-tabbox-contrast-after.png

Thanks,

Sebastian Kügler

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/108400/">http://git.reviewboard.kde.org/r/108400/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for kwin and Plasma.</div>
<div>By Sebastian Kügler.</div>

<p style="color: grey;"><i>Updated Jan. 14, 2013, 9:08 a.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">adding plasma as I would like to get some feedback on whether highlight \
is the right element to use in general or whether we should migrate away from it as \
it seems to be unusable with the default theme for our uses.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Improve highlighted contrast in thumbnail tabbox

Air&#39;s hovered svg provides only a thin frame around the borders, too
little to quickly spot the highlighted item when the whole widget is
only around for a few milliseconds (as is usual with the tabbox).

This patch paints a rectangle with rounded corners behind the
highlighted item instead, making it much easier to spot the currently
highlighted item.

Aimed for master and KDE/4.10.</pre>
  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Tested with Air, Oxygen and Slim Glow, all work as expected, all show \
contrast improvements, while still looking beautiful. :)</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>kwin/tabbox/qml/clients/thumbnails/contents/ui/main.qml <span style="color: \
grey">(4c33703d54c84fd54da94f821234e4cbd9c1c001)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/108400/diff/" style="margin-left: \
3em;">View Diff</a></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments \
</h1>

<ul>

 <li><a href="http://git.reviewboard.kde.org/media/uploaded/files/2013/01/14/kwin-tabbox-contrast-before.png">before, \
try spotting the highlighted item</a></li>

 <li><a href="http://git.reviewboard.kde.org/media/uploaded/files/2013/01/14/kwin-tabbox-contrast-after.png"> \
after, much easier to find</a></li>

</ul>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[prev in list] [next in list] [prev in thread] [next in thread] 